Skip to content

fix(rds): re-derive family ProjectedCoverage after cap, override and dedupe - #2287

Merged
cristim merged 1 commit into
mainfrom
fix/2214-rederive-rds-coverage-v2
Oct 20, 2026
Merged

cristim merged 1 commit into
mainfrom
fix/2214-rederive-rds-coverage-v2

Conversation

@cristim

@cristim cristim commented Oct 20, 2026

Copy link
Copy Markdown
Member

Summary

Re-derives family ProjectedCoverage after cap, override and dedupe for RDS. Single commit of about 105 lines, replacing two commits where the first carried a stray backup file.

Supersedes the stacked branch fix/2214-rederive-rds-coverage, now that its base (#2284) is squash-merged.

Verification

go vet, go test -count=1 ./..., golangci-lint and scripts/test-git-secrets-allowlist.sh all pass.

Closes #2214

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

  • Run on-demand review

This review includes 6 billable files and costs up to $1.50.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 20 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 87 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: LeanerCloud/cloud-commitments-cli/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: aab7db8b-db3d-4d41-865b-2310cefb5cb1
📥 Commits

Reviewing files that changed from the base of the PR and between ab05b6a and 1065362.

📒 Files selected for processing: 6
  • CHANGELOG.md
  • cmd/helpers.go
  • cmd/instance_limit_savings_plan_test.go
  • cmd/multi_service.go
  • cmd/multi_service_max_instances_test.go
  • cmd/multi_service_rederive_coverage_test.go
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

…dedupe

--target-coverage sizes RDS recs by family normalized units and writes a
family-wide ProjectedCoverage. --max-instances, --count-override and the
duplicate-RI check then change Count, leaving that value stale. Call
RederiveFamilyCoverage once on the final set in scoreLimitAndDisplay, only
for --target-coverage runs (the legacy --coverage path writes a per-pool
value it would overwrite) and never on the CSV path (no coverage map).

Closes #2214

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cristim

cristim commented Oct 20, 2026

Copy link
Copy Markdown
Member Author

Gate note (claude-cc-libs)

Rebased onto main after #2286 merged. The only conflict was CHANGELOG.md, resolved by keeping both entries. Excluding CHANGELOG.md, git diff origin/main 106536204013f4c04105010ad94c292f3f3110a5 is identical to the reviewed 57960c1d diff apart from hunk line numbers. Re-verified on the combined tree: go vet, go test -count=1 ./cmd/... and golangci-lint all pass.

@cristim
cristim force-pushed the fix/2214-rederive-rds-coverage-v2 branch from 57960c1 to 1065362 Compare October 20, 2026 04:42
@cristim

cristim commented Oct 20, 2026

Copy link
Copy Markdown
Member Author

Merge gate verdict (claude-cc-libs)

Every gate holds at head 1065362:

  • Two independent reviews approve the reviewed head 1065362. The branch was then updated from main, and the PR diff is byte-identical to the reviewed diff (compared mechanically).
  • CI is green on 1065362, which is the reviewed change on top of current main.
  • 0 unresolved threads; MERGEABLE/CLEAN.

CodeRabbit is waived as a merge gate under the 2026-10-19 decision. Squash-merging.

@cristim
cristim merged commit 615d700 into main Oct 20, 2026
12 checks passed
@cristim
cristim deleted the fix/2214-rederive-rds-coverage-v2 branch October 20, 2026 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(cli): RDS ProjectedCoverage stays stale after --max-instances, count override or dedupe

1 participant