Skip to content

refactor(cmd): split multi_service_helpers.go by pure moves - #2290

Merged
cristim merged 5 commits into
mainfrom
refactor/1834-split-multi-service-helpers
Oct 20, 2026
Merged

cristim merged 5 commits into
mainfrom
refactor/1834-split-multi-service-helpers

Conversation

@cristim

@cristim cristim commented Oct 20, 2026

Copy link
Copy Markdown
Member

Part of #1834

Splits cmd/multi_service_helpers.go (843 lines, second largest over the 500-line limit) by pure moves. It is now 328 lines.

New files:

  • multi_service_engine_data.go (130): engine version data fetching
  • multi_service_region_recs.go (~220): per-region recommendation fetch, coverage overrides, family expiry
  • multi_service_fetch_all.go (~197): duplicate check and fetch-all orchestration

Four commits, each at most 400 added+deleted lines.

Proof it is a pure move:

  • A go/ast tool dumps every top-level non-import declaration (doc comment included) of the non-test files in cmd/, byte for byte, sorted. The dump is identical before and after every commit (sha1 95b11f478d86... both sides, diff empty).
  • go vet ./cmd/... clean; go test -count=1 ./cmd/... passes.
  • Only import blocks were edited.

Independent of #2289 (multi_service.go); the two touch different files.

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

  • Run on-demand review

This review includes 5 billable files and costs up to $1.25.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 3 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 88 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: LeanerCloud/cloud-commitments-cli/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 7835fe59-1a9b-4700-8373-70fbe24de31b
📥 Commits

Reviewing files that changed from the base of the PR and between 80134ad and 71c05f8.

📒 Files selected for processing: 5
  • .gitallowed
  • cmd/multi_service_engine_data.go
  • cmd/multi_service_fetch_all.go
  • cmd/multi_service_helpers.go
  • cmd/multi_service_region_recs.go
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

cristim and others added 5 commits October 20, 2026 20:18
…_helpers.go

Pure move, no logic change (Part of #1834).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ice_helpers.go

Pure move, no logic change (Part of #1834).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…service_helpers.go

Pure move, no logic change (Part of #1834).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…_helpers.go

Pure move, no logic change (Part of #1834).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The pure move relocated AppLogger separator lines; the allowlist entry named only the old files. Part of #1834.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cristim
cristim force-pushed the refactor/1834-split-multi-service-helpers branch from 143e758 to 71c05f8 Compare October 20, 2026 18:21
@cristim

cristim commented Oct 20, 2026

Copy link
Copy Markdown
Member Author

Merge gate verdict (claude-cc-libs)

Every gate holds at head 71c05f8:

  • Two independent reviews approve the reviewed head 71c05f8. The branch was then updated from main, and the PR diff is byte-identical to the reviewed diff (compared mechanically).
  • CI is green on 71c05f8, which is the reviewed change on top of current main.
  • 0 unresolved threads; MERGEABLE/CLEAN.

CodeRabbit is waived as a merge gate under the 2026-10-19 decision. Squash-merging.

@cristim
cristim merged commit 2d6f7cf into main Oct 20, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant