Skip to content

refactor(cmd): split multi_service_engine_versions.go by concern - #2293

Merged
cristim merged 3 commits into
mainfrom
refactor/1834-split-engine-versions-v2
Oct 20, 2026
Merged

cristim merged 3 commits into
mainfrom
refactor/1834-split-engine-versions-v2

Conversation

@cristim

@cristim cristim commented Oct 20, 2026

Copy link
Copy Markdown
Member

Part of #1834.

Pure-move split of cmd/multi_service_engine_versions.go (604 lines, now 193) into _extended.go, _parse.go and _major.go, one commit each (346 / 172 / 266 add+del). No code changes; the invariant panic is untouched.

AST proof: /tmp/claude/revC-astdump (every top-level declaration with its doc comment, sorted) output of cmd/ is byte-identical before vs after at every commit.

Also: go vet, go test -count=1 ./cmd/..., golangci-lint run ./cmd/... and scripts/test-git-secrets-allowlist.sh (44 PASS) are green. No .gitallowed or .golangci.yml entries name this file, so no changes there.

🤖 Generated with Claude Code

cristim and others added 3 commits October 20, 2026 21:04
…ne_versions.go

Pure move of declarations, no code change (part of #1834).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ne_versions.go

Pure move of declarations, no code change (part of #1834).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e_engine_versions.go

Pure move of declarations, no code change (part of #1834).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

  • Run on-demand review

This review includes 4 billable files and costs up to $1.00.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 17 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 88 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: LeanerCloud/cloud-commitments-cli/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 252c7dc4-0e92-428b-a407-5bac25c41ac0
📥 Commits

Reviewing files that changed from the base of the PR and between 6b83149 and 4fabcc5.

📒 Files selected for processing: 4
  • cmd/multi_service_engine_versions.go
  • cmd/multi_service_engine_versions_extended.go
  • cmd/multi_service_engine_versions_major.go
  • cmd/multi_service_engine_versions_parse.go
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@cristim

cristim commented Oct 20, 2026

Copy link
Copy Markdown
Member Author

Merge gate verdict (claude-cc-libs)

Every gate holds at head 4fabcc5:

  • Two independent reviews approve the reviewed head 4fabcc5. The branch was then updated from main, and the PR diff is byte-identical to the reviewed diff (compared mechanically).
  • CI is green on 4fabcc5, which is the reviewed change on top of current main.
  • 0 unresolved threads; MERGEABLE/CLEAN.

CodeRabbit is waived as a merge gate under the 2026-10-19 decision. Squash-merging.

@cristim
cristim merged commit c07edc5 into main Oct 20, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant