chore(provider): rename stuttering ProviderConfig -> Config (isolated, quiet-tree) #39
Description
Summary
Rename the stuttering type provider.ProviderConfig -> provider.Config (and constructor param names accordingly). Pure mechanical stutter-fix, no behavior change.
Context
This was extracted from a larger, stale "pointer-refactor" idea (pass structs by pointer + rename + collapse dual value/pointer handling of DatabaseDetails/CacheDetails) found in an abandoned worktree during a July 2026 cleanup pass. The other two parts were deliberately declined:
- Pointer-passing introduces nil-ability + aliasing (new nil-guard burden) for no hot-path win.
- Collapsing the dual value/pointer
DatabaseDetails/CacheDetailshandling to pointer-only is correctness-risky: the dual-handling onmain(cmd/*.go, scheduler.go, coverage.go) is defensive because different producers emit value vs pointer forms; collapsing it risks a silent type-assertion miss unless every producer is audited first. Not worth it.
Only the rename is a clean, low-risk win, and only worth doing in isolation.
Why isolate + defer
ProviderConfig is used across the whole provider-construction path + tests, so the rename cascades widely and is a merge-conflict magnet. Do it as its own tiny PR only when no other PRs touch provider construction (a quiet-tree window), to avoid churning in-flight work.
Scope (keep it mechanical)
- Rename the type
ProviderConfig->Configin theproviderpackage and update all references/tests. - Do NOT change any signatures to pointers, and do NOT touch the
DatabaseDetails/CacheDetailsdual-handling. - Verify:
go build ./...+go test ./...green, golangci-lint clean,.golangci.ymlunchanged.
Acceptance
provider.ProviderConfigno longer exists;provider.Configused everywhere; all tests pass; zero behavior change.
Activity
cristim commentedon Oct 17, 2026
Checked against main: still valid (86 ProviderConfig references in about 15 files) and mechanical, but the issue asks for a quiet tree, and open PR #493 edits providers/gcp/provider.go and provider_test.go. Blocked on #493 and on a quiet tree.
cristim commentedon Oct 20, 2026
Claiming [claude-cc-libs]
fix(provider): drop the Deprecated marker from the ProviderConfig alias
refactor(provider): rename ProviderConfig to Config
fix(provider): drop the Deprecated marker from the ProviderConfig alias
refactor(provider): rename ProviderConfig to Config (#603)
refactor(aws): migrate to provider.Config
refactor(azure): migrate to provider.Config
refactor(gcp): migrate to provider.Config
chore(ci_cd_sanity_tests): re-pin pkg to provider.Config
refactor(provider): deprecate ProviderConfig alias
refactor(provider): migrate providers to provider.Config and deprecat…