Skip to content

refactor(provider): migrate providers to provider.Config and deprecate ProviderConfig - #609

Merged
cristim merged 5 commits into
mainfrom
refactor/39-migrate-provider-config
Oct 20, 2026
Merged

cristim merged 5 commits into
mainfrom
refactor/39-migrate-provider-config

Conversation

@cristim

@cristim cristim commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

Part of #39 (the issue only asks for the ProviderConfig -> Config rename; remaining: remove the deprecated alias once cloud-commitments-mcp and cloud-commitments-platform migrate. pkg/exchange stutters are not in the issue.)

Summary

  • Re-pin providers/aws, providers/azure, providers/gcp and ci_cd_sanity_tests to pkg at origin/main 205cf99 (v0.0.0-20261020191912-205cf99b8ef3; timestamp matches the commit time 19:19:12Z, the commit is main itself), which has provider.Config.
  • Migrate every provider and test use of provider.ProviderConfig to provider.Config (including doc comments).
  • Mark the ProviderConfig alias // Deprecated: use Config. in a separate final commit, with a CHANGELOG line.

Verification

Per module (pkg, aws, azure, gcp, ci_cd_sanity_tests), with and without GOWORK=off: build, vet, go test -timeout 300s -count=1 ./... all pass. golangci-lint with go.work active (local v2.11.4, CI pins v2.10.1): 0 issues, 0 SA1019.

Consumer uses of provider.ProviderConfig (still compile against the alias). mcp and platform run staticcheck with fatal warnings, so their next pkg bump fails lint (SA1019) until they migrate to provider.Config.

  • cloud-commitments-cli: 0
  • cloud-commitments-mcp: 86 uses in 20 files
  • cloud-commitments-platform: 36 uses in 14 files

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

  • Run on-demand review

This review includes 13 billable files and costs up to $3.25.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 21 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 88 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: LeanerCloud/cloud-commitments-go/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 67e1317e-9666-426f-8605-033a44c72cba
📥 Commits

Reviewing files that changed from the base of the PR and between fe9c574 and a08772f.

⛔ Files ignored due to path filters: 4
  • ci_cd_sanity_tests/go.sum is excluded by !**/*.sum
  • providers/aws/go.sum is excluded by !**/*.sum
  • providers/azure/go.sum is excluded by !**/*.sum
  • providers/gcp/go.sum is excluded by !**/*.sum
📒 Files selected for processing: 13
  • CHANGELOG.md
  • ci_cd_sanity_tests/go.mod
  • pkg/provider/interface.go
  • providers/aws/go.mod
  • providers/aws/provider.go
  • providers/aws/provider_test.go
  • providers/azure/accounts_cache.go
  • providers/azure/go.mod
  • providers/azure/provider.go
  • providers/azure/provider_test.go
  • providers/gcp/go.mod
  • providers/gcp/provider.go
  • providers/gcp/provider_test.go
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

cristim and others added 5 commits October 20, 2026 23:18
Re-pin pkg to origin/main 205cf99 (adds provider.Config) and replace
provider.ProviderConfig with provider.Config. Part of #39.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Re-pin pkg to origin/main 205cf99 (adds provider.Config) and replace
provider.ProviderConfig with provider.Config. Part of #39.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Re-pin pkg to origin/main 205cf99 (adds provider.Config) and replace
provider.ProviderConfig with provider.Config. Part of #39.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Re-pin pkg to origin/main 205cf99. Part of #39.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
All in-repo modules now use provider.Config, so mark the alias
Deprecated. Closes #39.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cristim
cristim force-pushed the refactor/39-migrate-provider-config branch from cd5ffbe to a08772f Compare October 20, 2026 21:24
@cristim

cristim commented Oct 20, 2026

Copy link
Copy Markdown
Member Author

Merge gate verdict (claude-cc-libs)

Every gate holds at head a08772f:

  • Two independent reviews approve the reviewed head a08772f. The branch was then updated from main, and the PR diff is byte-identical to the reviewed diff (compared mechanically).
  • CI is green on a08772f, which is the reviewed change on top of current main.
  • 0 unresolved threads; MERGEABLE/CLEAN.

CodeRabbit is waived as a merge gate under the 2026-10-19 decision. Squash-merging.

@cristim
cristim merged commit 03f40a3 into main Oct 20, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant