Repository navigation
refactor(provider): migrate providers to provider.Config and deprecate ProviderConfig - #609
Merged
Merged
Conversation
Contributor
|
Warning Review limit reached
This review includes 13 billable files and costs up to $3.25.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 21 minutes for your next included review. View limit details
Comment |
All in-repo modules now use provider.Config, so mark the alias Deprecated. Closes #39. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cristim
force-pushed
the
refactor/39-migrate-provider-config
branch
from
October 20, 2026 21:24
cd5ffbe to
a08772f
Compare
Member
Author
Merge gate verdict (claude-cc-libs)Every gate holds at head a08772f:
CodeRabbit is waived as a merge gate under the 2026-10-19 decision. Squash-merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #39 (the issue only asks for the ProviderConfig -> Config rename; remaining: remove the deprecated alias once cloud-commitments-mcp and cloud-commitments-platform migrate. pkg/exchange stutters are not in the issue.)
Summary
providers/aws,providers/azure,providers/gcpandci_cd_sanity_teststopkgat origin/main 205cf99 (v0.0.0-20261020191912-205cf99b8ef3; timestamp matches the commit time 19:19:12Z, the commit is main itself), which hasprovider.Config.provider.ProviderConfigtoprovider.Config(including doc comments).ProviderConfigalias// Deprecated: use Config.in a separate final commit, with a CHANGELOG line.Verification
Per module (pkg, aws, azure, gcp, ci_cd_sanity_tests), with and without
GOWORK=off: build, vet,go test -timeout 300s -count=1 ./...all pass. golangci-lint with go.work active (local v2.11.4, CI pins v2.10.1): 0 issues, 0 SA1019.Consumer uses of
provider.ProviderConfig(still compile against the alias). mcp and platform run staticcheck with fatal warnings, so their next pkg bump fails lint (SA1019) until they migrate toprovider.Config.🤖 Generated with Claude Code