[IAmJSD]

Why

Follow-up promised in #491's review thread (CodeRabbit on pkg/recfilter/dedupe.go:96). #491 added the coveringCommitmentLister selector to recfilter.DuplicateChecker, so a savings plan billed to another subscription but applied to this one suppresses a re-buy. But providers/azure/go.mod still pinned pkg at 205cf99b, from before that selector. A standalone Azure-module build (GOWORK=off, which is how cli and mcp consume it) therefore never called GetCoveringCommitments, so those plans were left out of duplicate checks. The pin could only be bumped once #491's pkg change was on main.

What

• providers/azure/go.mod: bump github.com/LeanerCloud/cloud-commitments-go/pkg from v0.0.0-20261020191912-205cf99b8ef3 to v0.0.0-20261026065151-8e125008e26c (the fix(azure): count savings plans billed to another subscription in the duplicate check #491 merge, via GOWORK=off go get ...@8e125008). go mod tidy changed nothing else, and no other dependency moved.
• TestDuplicateChecker_PlanBilledToAnotherSubscription: drop the coveringView adapter, which fed the covering list in as inventory and so hid the stale pin. The test now passes the real Client to DuplicateChecker, so the standalone build is tested end to end.

Verification

Fail-before: with the test change applied and the old pin, GOWORK=off go test -run TestDuplicateChecker_PlanBilledToAnotherSubscription ./services/savingsplans/ fails 4 of 5 cases (single-ours, single-rg-ours, shared, management-group; the recommendation is not suppressed). single-other passes because it expects no suppression. With the new pin, all 5 pass.

Also run:

• GOWORK=off in pkg and providers/azure: go build ./..., go vet ./..., go test -race -count=1 ./...
• Workspace mode: go vet ./... and go test -race -short -count=1 ./... in all five modules
• golangci-lint v2.10.1 with the repo .golangci.yml (as CI runs it) in pkg and providers/azure, in workspace and GOWORK=off mode: 0 issues. gocyclo -over 10 on non-test files: clean
• Secrets scan of the changed files: clean

Note

cli and mcp also need their pkg and providers/azure pins bumped to pick up #491. Until they are, their builds still use the pre-#491 duplicate check.

🤖 Generated with Claude Code

[coderabbitai]

Caution

Review failed

The pull request is closed.

Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[IAmJSD]

Independent review (IAmJSD's agent, fresh context, given only the diff, the issue and the PR text): VERDICT: APPROVE d4bfe556ae768961596173dc515ef0e978b214a9

Blocking:

• none

Non-blocking:

• The note says cli and mcp need pin bumps. The platform needs one too. Its go.mod pins pkg v0.0.0-20261020053130-ff6225d5ff04 and providers/azure v0.0.0-20261017134002-3def3f898617, which both predate fix(azure): count savings plans billed to another subscription in the duplicate check #491. MVS will pick up the newer pkg once platform bumps providers/azure past this PR, but until then the platform's duplicate check misses plans billed to another subscription.
• The bump also brings in every other pkg change between 205cf99b and 8e125008: chore(lint): reorder pkg structs for fieldalignment #589, refactor(provider): migrate providers to provider.Config and deprecate ProviderConfig #609 (provider.Config migration), fix(ci): bump Go to 1.26.10 for GO-2026-6809 #613, feat(ladder): report the net existing commitment Allocate sized the gap against #614 and fix(ladder): stop subtracting existing commitment from residual baselines #441. The standalone Azure build and tests pass with them, so this is only a heads-up for consumers who bump.

Attacked:

• Checked that 8e125008 is on main and is the fix(azure): count savings plans billed to another subscription in the duplicate check #491 merge, and that the pseudo-version timestamp 20261026065151 matches its UTC commit time. Under GOWORK=off, go mod verify passes and go mod tidy in providers/azure changes nothing.
• GOWORK=off, default -mod=readonly, in pkg and in providers/azure: go build ./..., go vet ./... and go test -race -count=1 ./... all pass (13 and 14 test packages ok, no FAIL).
• Fail-before: with the new test and main's go.mod/go.sum (old pin), GOWORK=off go test -run TestDuplicateChecker_PlanBilledToAnotherSubscription ./services/savingsplans/ fails single-ours, single-rg-ours, shared and management-group, while single-other passes. All five pass with the new pin, and also in workspace mode. Removing the coveringView adapter is what makes the test exercise the real Client through DuplicateChecker's own selector, so the test now proves the claim.

Body-stale:

• none (the note's list of consumers is incomplete, see above)

_{Reviewer: rC6. Bar while the maintainers are away (set by IAmJSD as acting owner): one approving independent review on the head, two for money, auth and security paths.}

[IAmJSD]

Local verification at d4bfe556ae768961596173dc515ef0e978b214a9 (main merged in; the PR's diff is unchanged, so earlier reviews carry over; every module builds, vets and passes go test -race). CI Success and pre-commit green. Merged by IAmJSD's agent at IAmJSD's request (acting owner while the maintainers are away), under the bar IAmJSD set: an approving independent review (rC6). Squash-merged at exactly d4bfe556ae768961596173dc515ef0e978b214a9.