Skip to content

ci: remove the redundant integration-tests job - #111

Merged
cristim merged 2 commits into
mainfrom
ci/2-drop-redundant-integration-job
Oct 20, 2026
Merged

cristim merged 2 commits into
mainfrom
ci/2-drop-redundant-integration-job

Conversation

@cristim

@cristim cristim commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

Part of #2 (item 9)

No file in the repo carries a //go:build integration tag, so the integration-tests job only re-ran the unit suite under -race. Removes the job, its ci-success.needs entry and its mention in .github/workflows/README.md. Every other gate is unchanged. The make test-integration target is left alone for local use.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • CI
    • Removed the integration test job from the continuous integration workflow.
    • The CI success gate now depends on linting, workflow validation, unit tests, security scanning, and build checks only.
  • Documentation
    • Updated CI documentation to reflect the current set of required checks.

No file carries a //go:build integration tag, so the job re-ran the unit suite. Drop it and its ci-success.needs entry; every other gate is unchanged. Part of #2 (item 9).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: LeanerCloud/cloud-commitments-mcp/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 0c4aab23-a9a7-444b-b765-00cf77d0f39d
📥 Commits

Reviewing files that changed from the base of the PR and between fec4dd3 and 8ac1a0b.

📒 Files selected for processing: 2
  • .github/workflows/README.md
  • .github/workflows/ci.yml
💤 Files with no reviewable changes: 1
  • .github/workflows/ci.yml

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

📝 Walkthrough

The CI workflow no longer runs the integration-tests job or includes it in the ci-success requirements. The workflow documentation reflects this change and lists the remaining required jobs.

Changes: CI Workflow Update

Layer / File(s) Summary
Remove integration test job and update CI gate
.github/workflows/ci.yml, .github/workflows/README.md
The workflow removes integration test execution, coverage merging, and artifact upload. The ci-success gate and documentation no longer include integration-tests.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 8ac1a

The CI cleanup is consistent and leaves local integration testing available, with no identified merge-blocking risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: removing the redundant integration-tests CI job.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@cristim

cristim commented Oct 20, 2026

Copy link
Copy Markdown
Member Author

Merge gate verdict (claude-cc-libs)

Every gate holds at head 8ac1a0b:

  • Two independent reviews approve the reviewed head 79c9aae. The branch was then updated from main, and the PR diff is byte-identical to the reviewed diff (compared mechanically).
  • CI is green on 8ac1a0b, which is the reviewed change on top of current main.
  • 0 unresolved threads; MERGEABLE/CLEAN.

CodeRabbit is waived as a merge gate under the 2026-10-19 decision. Squash-merging.

@cristim
cristim merged commit 5f9359b into main Oct 20, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant