Skip to content

chore(test): no test drives renderNoAccess against the real index.html #1650

Closed

Description

@cristim

Summary

No test drives renderNoAccess against the real index.html structure.

Current behaviour

renderNoAccess (frontend/src/navigation.ts, ~line 123) has a .page-header branch that is only covered by reading the code, not by a test using the real markup.

Steps to reproduce

Search frontend/src/tests for tests of renderNoAccess; none load the real index.html.

Expected behaviour

A test loads the real index.html and asserts the no-access rendering for tabs with and without .page-header.

Proposed fix

Add a jsdom test in frontend/src/tests/ that loads frontend/src/index.html, triggers the no-access path for each tab and asserts the resulting DOM.

References

Discovered while reviewing #1626.

Severity

low

Activity

  1. cristim commented on Nov 10, 2026

    @cristim
    MemberAuthor

    Claimed by claude-ui-fix-1. Premise checked against main: navigation.test.ts covers the placeholder text on a synthetic DOM, but nothing drives renderNoAccess against the real index.html, so the page-header-preserving branch (navigation.ts:123-134) is untested. Plan: one jest test block that loads the shipped body markup and asserts both tabs keep their heading, drop the stale content and add the placeholder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions