Repository navigation
fix(ladder): config dialog overflows at 390px and its Save button cannot be tapped #1665
Description
Discovered while verifying #1623 (burndown run 2026-11-04).
Summary
At 390px width the Commitment Laddering config dialog is wider than the viewport (about 642px, the document overflows by about 252px) and its inputs overlap the Save button, so a real tap on Save does not reach it. Phone users cannot save a ladder config.
Current behaviour
On main @ 8e05cc4: Admin > Purchasing > Commitment Laddering > Edit at 390x844 (touch): the dialog overflows horizontally and a pointer tap on Save times out because another element intercepts it.
Steps to reproduce
- Open the ladder config dialog at 390x844 with touch emulation.
- Measure the dialog width and try tapping Save.
Expected behaviour
The dialog fits the viewport at 390px and Save is tappable (44px target, not covered).
Proposed fix
Constrain the ladder config dialog/form width on phones (max-width: 100%, inputs min-width: 0/width: 100% in the 640px block of frontend/src/styles/ladder-form.css / modals.css) and add a 390px touch e2e that taps Save.
References
- Found verifying ui(ladder): taller ramp-schedule field with an inline JSON error #1623; reproduced identically on main.
- Severity: medium (a primary action is unusable on phones).
Activity
cristim commentedon Nov 4, 2026
Claiming: claude-as-qa-2 (fleet), assigned by the coordinator. Plan: reproduce on current main at 390x844 with touch emulation in a failing Playwright spec (dialog width ≤ viewport, Save is tappable and not covered, target ≥44px), then constrain the ladder config dialog and form at phone widths. TDD, committed locally while the repo is at the PR cap, opened as a PR when a slot frees.
cristim commentedon Nov 5, 2026
Claimed by claude-as-qa-2: local fix committed with a phone-width Playwright regression test, waiting for a PR slot.
cristim commentedon Nov 9, 2026
Claimed by claude-qa-ui-3 (fleet lane cc-platform-2-ui-qa), taking over the stale claim of claude-as-qa-2 (last update 2026-11-05, never pushed). Their finished local commit (3f01dcec: 6 lines of CSS making the ladder configs table container its own containing block, plus a phone e2e spec at 320/390/768/1440px) is not on main. Plan: rebase it onto current main with credit, prove fail-before on main and pass-after with the spec, run the frontend lint gate and pre-commit properly, then one PR with Closes #1665 and self-merge on green.