Skip to content

Deploy #702 PR3b (#1832) only 24h after the attempt journal (#1824, 000161) is live in each environment #1835

Closed

Description

@cristim

Summary

#1832 (#702 PR3b) lifts the refusal of Redshift re-drive and Retry. A Redshift purchase row dispatched before the attempt journal (#1824, migration 000161) was live in an environment has no journal record. If AWS changes that tuple's offering within the 24h re-drive horizon, a retry of such a row could buy a second reserved node. So in every environment, #1832 must be deployed no earlier than 24h after #1824 and 000161 are live there.

Dev is handled by merge timing: #1824 went live on dev at 2026-11-06T23:38:42Z, so #1832 merges no earlier than 2026-11-07T23:39Z. Prod deploys separately, so the same rule needs an explicit runbook step.

Steps to verify the gap

  1. Check the prod deploy runbook and known_issues/: neither records the 24h ordering between feat(purchase): record Redshift purchase attempts in a durable journal #1824 (and 000161) and fix(purchase): allow Redshift re-drive behind the retry, lineage and journal gates #1832.
  2. A prod release that ships feat(purchase): record Redshift purchase attempts in a durable journal #1824 and fix(purchase): allow Redshift re-drive behind the retry, lineage and journal gates #1832 together, or ships fix(purchase): allow Redshift re-drive behind the retry, lineage and journal gates #1832 within 24h of feat(purchase): record Redshift purchase attempts in a durable journal #1824, would open the window.

Expected behaviour

The prod (and any other environment's) release process makes sure #1832 is deployed at least 24h after #1824 and migration 000161 are live in that environment.

Proposed fix

References

Severity

Medium (money path: a possible duplicate purchase in a narrow deploy window).

🤖 Generated with Claude Code

Activity

  1. cristim commented on Nov 9, 2026

    @cristim
    MemberAuthor

    Claimed by claude-darling: local commits (docs change: DEPLOYMENT.md release-ordering step plus a line in known_issues/39). Premise re-checked on main: neither file records the 24h ordering, #1824 (000161) and #1832 are both merged. Platform is at its PR cap, so this stays local until a slot opens.

  2. cristim commented on Nov 9, 2026

    @cristim
    MemberAuthor

    Claimed by claude-darling: committed locally (docs only: DEPLOYMENT.md release-ordering step with the two-deploy procedure and rollback note, plus a line in known_issues/39). Two adversarial review passes closed. Will push and open the PR when platform has a PR slot.

  3. added a commit that references this issue on Nov 9, 2026
    c87774e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions