Skip to content

docs: link the unreachable claim-funnel entry to its follow-up issue - #1818

Merged
cristim merged 1 commit into
mainfrom
docs/1814-known-issues-link
Nov 6, 2026
Merged

cristim merged 1 commit into
mainfrom
docs/1814-known-issues-link

Conversation

@cristim

@cristim cristim commented Nov 6, 2026

Copy link
Copy Markdown
Member

Summary

Follow-up to #1812 (issue #399), from claude-ui-fix-1's review. known-issues.md already records that the claim funnel's approved from-set entry is unreachable now that the execute-by-ID path is gone. This adds a link to the issue that tracks removing it, #1814.

Documentation only: one line in known-issues.md.

Refs #1814

🤖 Generated with Claude Code

Refs #399, #1814

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cristim cristim added impact/internal Team-internal only triaged Item has been triaged priority/p3 Polish / idea / may never ship severity/low Minor harm urgency/this-quarter Within the quarter effort/s Hours type/docs Documentation labels Nov 6, 2026
@coderabbitai

coderabbitai Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 44 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between c318a6b and e390dc7.

Files selected for processing: 1

  • known-issues.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@cristim

cristim commented Nov 6, 2026

Copy link
Copy Markdown
Member Author

APPROVED e390dc7 by claude-qa-ui-3

Docs-only, one line in known-issues.md.

@cristim

cristim commented Nov 6, 2026

Copy link
Copy Markdown
Member Author

APPROVED e390dc7 by claude-cc-platform

Cold review, docs only (known-issues.md +1/-1). The added text, "tracked in issue #1814", matches its target: #1814 is open and titled "chore(purchase): drop the unreachable 'approved' entry from the claim funnel's from-set", which is exactly what the entry (claimAndExecuteWithin still claims from approved) says is left to do. The wording follows the file's "(issue #N)" style, and the sentence still reads cleanly. The body says Refs #1814 and closingIssuesReferences is empty, so merging won't close the follow-up. CI was still pending when I checked (1 pass, 35 pending); it needs to go green before merge.

@cristim
cristim merged commit 670e8e4 into main Nov 6, 2026
41 checks passed
@cristim
cristim deleted the docs/1814-known-issues-link branch November 6, 2026 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/s Hours impact/internal Team-internal only priority/p3 Polish / idea / may never ship severity/low Minor harm triaged Item has been triaged type/docs Documentation urgency/this-quarter Within the quarter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant