Repository navigation
fix: unblock Dependabot security updates and polish repository presentation - #2
Merged
Merged
Conversation
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
… add LibreSign funding Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…tions Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
After merging #1, the automatic Dependabot security-update run #43740390386 failed because its dependency graph could not resolve patched transitive versions of
minimatchandqs:@nextcloud/vue/ WebDAV, ESLint and Stryker pulled inminimatch9/10, whereas the advisory requires at least 11.0.1.typed-rest-client@2.3.1, which pinsqs@6.15.1, affected by security advisories.npm run audit, which previously ignored moderate-severity issues.Changes
minimatch@^11.0.1andqs@^6.16.1and regeneratepackage-lock.jsonwith Node 24 / npm 11. The resolved versions areminimatch@11.0.8andqs@6.17.1.npm run auditenforce the moderate severity threshold, automatically tightening the existingNPM auditworkflow without disabling any check..github/FUNDING.ymlwithgithub: libresign.Repository About metadata is not a versioned file. It has already been updated directly: website
https://librecode.coop/and relevant Nextcloud / communications topics.Validation
Validated in an isolated worktree using Node 24.22.3 and npm 11.19.1:
npm ci --include=dev --include=optional: successnpm ls minimatch qs: patched versions throughout the dependency treenpm run audit: 0 vulnerabilities, including moderate severitynpm run lint,npm run lint:styles,npm run ts:check: passnpm run test:unit: 114 tests passnpm run test:package: 4 tests passnpm run package:app: passnpm run test:mutation: 93.02% score (above the 85% threshold)git diff --check: passReview considerations
The transitive
minimatchoverride crosses a major version boundary for some upstream libraries. The existing unit/build/mutation checks passed, but the PR's browser/integration matrix must also pass before merging. Revisit and remove the overrides when upstream dependency ranges natively accept fixed versions. No merge is requested in this PR.