Repository navigation
test(ci): isolate AppConfig-dependent policy integration checks - #9350
Merged
Merged
Conversation
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
deleted the
fix/phpunit-policy-appconfig-isolation-20261104
branch
November 4, 2026 18:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #9343 only updates the Bats GitHub Action, yet MySQL, PostgreSQL, MariaDB, and SQLite PHPUnit workflows fail on two integration tests. Both failures persist on a rerun of the failed jobs.
LibreSign's API/integration test base temporarily replaces global
IAppConfigwith the in-memoryAppConfigOverwrite. The Nextcloud container may retain an app-scopedPolicySourceconstructed with that replacement, causing later integration tests that expect real database persistence to load defaults or miss writes. Related test contamination was documented on #9238/#9242.Changes
Validation
bee9aafwas verified GPG-signed and DCO-compliant.Related: #9343, #9238, #9242.