Repository navigation
fix: restore legacy callback on completed signatures - #9423
Closed
vitormattos wants to merge 1 commit into
Closed
vitormattos wants to merge 1 commit into
vitormattos wants to merge 1 commit into
Conversation
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Contributor
Code Metrics Report
Details | | main (7154513) | #9423 (6a9a30f) | +/- |
|---------------------|----------------|-----------------|-------|
+ | Coverage | 76.1% | 76.2% | +0.0% |
| Files | 499 | 499 | 0 |
| Lines | 28577 | 28577 | 0 |
+ | Covered | 21775 | 21781 | +6 |
+ | Test Execution Time | 2s | 1s | -1s |Code coverage of files in pull request scope (0.0% → 100.0%, patch 100.0%)
Reported by octocov |
This was referenced Nov 9, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #9426. The LibreSign 16 development line will remove the proprietary callback transport rather than repair it. The existing native Nextcloud completion event and Webhook Listeners replace delivery; integrators retrieve PDFs separately with authorization.
Regression reproduced in disposable Nextcloud 36 / LibreSign main
With the existing implementation, a genuine unauthenticated browser signing produced a
SignedPDF and a nativeSigningRequestCompletedEventwebhook, but the legacy per-requestcallbackreceived no HTTP POST.SignedCallbackListenercheckedgetUpdatedFields()['signed']on a LibreSign File entity. This field does not exist; completion is represented byFileStatus::SIGNED. The listener therefore skipped the callback.Focused change
FileStatus::SIGNED; ignore partial signatures and unrelated events.Runtime evidence (isolated, synthetic)
uuid,status, andfile(265,017 bytes), and 1 native completion POST.git diff --check: passed./home/username/projects/libresign-external-homolog-20261109/runtime/evidence/(host Poland; no secrets in PR).Caveat: this fix deliberately restores callbacks only when the document is fully signed; it is not a new aggregate webhook or a per-signature callback contract.