Repository navigation
refactor(viewer): upgrade to beta.21 and remove Dialogs 7 isolation - #9461
Merged
github-actions[bot] merged 4 commits intoNov 13, 2026
Conversation
Bumps [@nextcloud/viewer](https://github.com/nextcloud/viewer) from 2.0.0-beta.20 to 2.0.0-beta.21. - [Commits](https://github.com/nextcloud/viewer/commits) --- updated-dependencies: - dependency-name: "@nextcloud/viewer" dependency-version: 2.0.0-beta.21 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…anup Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Contributor
Code Metrics ReportNote: Metrics describe the revision analyzed by the successful PHPUnit run. Newer commits with pending, canceled or failed checks may not yet be represented in this report.
Details | | main (676d88e) | #9461 (37d64f3) | +/- |
|---------------------|----------------|-----------------|------|
| Coverage | 76.2% | 76.2% | 0.0% |
| Files | 500 | 500 | 0 |
| Lines | 28581 | 28581 | 0 |
| Covered | 21784 | 21784 | 0 |
- | Test Execution Time | 3m46s | 3m51s | +5s |Reported by octocov |
vitormattos
approved these changes
Nov 13, 2026
github-actions
Bot
deleted the
dependabot/npm_and_yarn/src/viewer/nextcloud/viewer-2.0.0-beta.21
branch
November 13, 2026 18:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade
@nextcloud/viewerfrom2.0.0-beta.20to2.0.0-beta.21and remove the temporary Dialogs 7 isolation introduced by #9301. The updated Viewer and its Image Editor now both declare peer compatibility with@nextcloud/dialogs8.Cleanup of
TODO(viewer-compat)src/viewer/bridge, its installation boundary, and the rootpostinstallcommand.@nextcloud/viewerimports and update the focused Viewer mocks.Preserve behavior and security
Do not replace LibreSign's existing
getViewer()/getHandlers()/canView()behavior or its signed-PDF UUID safeguards. The native PDF handler must not receive the original owner'snodeId, even for an authenticated viewer; the existing regression cases test this boundary.Keep the permanent Dialogs 8 notification/file-picker regression tests. Upstream
nextcloud/files_pdfviewerstill registersfiles_pdfviewer-main.cssthroughLoadViewerListener, although Vite emits its styles as CSS chunks. The Playwright-only empty-file fixture therefore remains temporarily; commite1f43d2areplaces its passive TODO with a fail-on-upstream-change CI guard. CI now fails explicitly when the CSS file appears or the PHP registration changes, requiring re-validation and removal/update of the fixture.CI evidence before cleanup
dca55c8, Build Javascript built successfully but then deliberately failed the compatibility guard introduced in chore(deps): adopt dialogs 8 with isolated native viewer #9301 withViewer cleanup available. The strict peer dependency probe completed successfully.footer-policy-hierarchy-ui.spec.tstimed out in a policy selector. That failure is outside the native Viewer paths; attribution remains unproven.f43a7ded. The complete CI for that head must be checked before declaring merge readiness.Review checklist
viewer-compatcontrols whose prerequisite is met.npm ci, direct dependency tree, TypeScript, lint (0 errors, 23 warnings) and production build locally.Related: #9301; #9104. No merge is requested as part of this preparation.
Follow-up cleanup validation
Commit
7f98048dremoves the temporary Vue deduplication lines fromvite.config.mjsandvitest.config.js, restoring their pre-#9301 configuration. This was verified against the original #9301 patch. An isolated npm installation (Node 24/npm 11) has one Vue 3.5.45 and one@nextcloud/vue9.14.1; focused tests passed (19/19),npm run ts:checkpassed, ESLint passed with 0 errors and 23 warnings, andnpm run buildsucceeded. The empty CSS fixture in.github/workflows/playwright.ymlis still required by the current upstreamfiles_pdfviewersource. This was subsequently converted into an actionable CI guard in signed DCO commite1f43d2a, with four synthetic cases verified locally: current broken upstream stays supported; upstream CSS appearing, removal of the registration, or both changes trigger a CI error instructing cleanup. The actual upstream repair belongs innextcloud/files_pdfviewer(review/removal of its staleUtil::addStylecall and browser verification). The complete CI for HEADe1f43d2aremains the final merge gate.