Skip to content

Change from gRPC to Named Pipes #374

Closed

Description

@RandallFlagg

Today there is a need to install asp.net core in addition to .net core because of gRPC.
Also, inorder to communicate in a faster and better way between proccesses(IPC) of LogExpert we will change the communication from gPRC to Named Pipes.
gPRC will be used probably in a differnt part of the code(e.g. source of log) but not for the IPC purpose.

The reason choosing this was .net core support and cross platform.

Activity

  1. changed the title [-]I am trying to improve the ipc(remove the grpc.core). I am trying to test the 1 instance(enable/disable) but can't seem to make it work. @Hirogen can you help? I am on the Devlopment branch. I get an exception on line 159 in `Program.cs` `client.NewWindowOrLockedWindow(new Grpc.FileNames { FileNames_ = { args } });` Exception: The SSL connection could not be established, see inner exception. InnerException: Cannot determine the frame size or a corrupted frame was received.[/-] [+]Change from gRPC to Named Pipes[/+] on Apr 1, 2025
  2. Hirogen commented on Apr 2, 2025

    @Hirogen
    Member

    What is the USE CASE for InterProcess communications, why would I want to communicate between logexpert processes, is this really necessary?

  3. RandallFlagg commented on Apr 2, 2025

    @RandallFlagg
    ContributorAuthor

    What is the USE CASE for InterProcess communications, why would I want to communicate between logexpert processes, is this really necessary?

    Same question I was asking my self from the begining. Since you are the project lead and owner I though you knew. :)
    Luckaliy we have the code to answer your question.

    service LogExpertService
    {
    // Sends a log message
    rpc SendLog (LogRequest) returns (LogReply) ;
    rpc LoadFiles (FileNames) returns (FilesReply);
    rpc NewWindow (FileNames) returns (FilesReply);
    rpc NewWindowOrLockedWindow (FileNames) returns (FilesReply);
    //is this really needed?
    rpc WindowClosed(google.protobuf.Empty) returns (google.protobuf.Empty);
    rpc GetLogWindowCount(google.protobuf.Empty) returns (Count);
    }

  4. Hirogen commented on Apr 3, 2025

    @Hirogen
    Member

    yeah I implemented that, because that was in the old code, but I could never find a real use case where to use that.

  5. RandallFlagg commented on Apr 3, 2025

    @RandallFlagg
    ContributorAuthor

    Maybe let's open it for discussion so people can say what they need from a multiple window/instance of LogExpert. The only one I can think of is to move tabs between windows.

  6. locked and limited conversation to collaborators on Apr 3, 2025
  7. converted this issue into a discussion #375 on Apr 3, 2025
  8. linked a pull request that will close this issue380 configure port used by logexpert #389on May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions