1536 ib neighborhood radius automatic size checking - #1736
Draft
danieljvickers wants to merge 5 commits into
Draft
1536 ib neighborhood radius automatic size checking#1736danieljvickers wants to merge 5 commits into
danieljvickers wants to merge 5 commits into
Conversation
…a bounds check to get the temporary values
|
Claude Code Review Head SHA: d0e083e Files changed:
Findings:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Immersed Boundary cases have one extra layer of tediousness due to the IB neighborhood radius needing ot be recomputed based upon the number of ranks. This causes significant problems when attempting to run the same case on CPUs vs. GPUs (because one may use more CPUs for the same case) and in strong scaling scenarios.
To address this, this PR allows users to let MFC automatically compute the IB Neighborhood radius. The code computes the largest width required for any IB in the simulation and the largest processor width. These are used to approximate a size, with an additional 10% safety factor on the neighborhood size for safety.
This is not ideal, as it does not consider things like the orientation of the IB for reducing the size further. If particle forces are desired, it is always recommended to compute the IB neighborhood radius that one desires. However, for uniform distributions of small IBs, this will often produce optimal results with no modification to the case file.
To enable automatic radius checking, just set
ib_neighborhood_radius: 0in the case file, which is also the new default.Closes #1536
Type of change (delete unused ones)
Testing
How did you test your changes?
2D ranks on GNU for increasing IB size.
Checklist
Check these like this
[x]to indicate which of the below applies.See the developer guide for full coding standards.
GPU changes (expand if you modified
src/simulation/)AI code reviews
Reviews are not retriggered automatically. To request a review, comment on the PR:
@claude full review— Claude full review (also triggers on PR open/reopen/ready)claude-full-review— Claude full review via label