Repository navigation
fix: [DataURLObject] keep commas in the data of non-base64 data URLs - #1501
Merged
Merged
Conversation
Per RFC 2397 only the first comma separates the header from the data.
Member
|
You're right, good catch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DataURLObjectsplits a non-base64 data URL on every comma, so any data URL whose payload contains a comma is rejected:>>> DataURLObject('data:text/plain,hello,world') MISPObjectException: Invalid Data URL: text/plain,hello,world - too many values to unpack (expected 2, got 3)Per RFC 2397 only the first comma separates the header from the data, and commas in the data are common (inline SVG path coordinates, CSV, plain text). This change splits on the first comma only; the base64 branch is unchanged.
Adds
tests/test_dataurlobject.py, the first tests for this class: the comma case fails before the change and passes after, and a base64 case guards the existing behaviour.Locally (Python 3.14):
pytest tests/test_*.py128 passed, 2 skipped; mypy reports no issues in the changed files.