Repository navigation
Conversation
Previously only extra_file1 through extra_file5 were read, so a sixth forcing file was silently ignored. Replace the five hard-coded names with a helper that collects any extra_fileN option from the config section, sorted by N, so an arbitrary number of extra files can be interpolated. Also validate the extra_fileN paths (existence, and that interp_method is ncremap) before doing any of the expensive culling/mapping work, instead of only checking right before each file is remapped at the end of the step. This avoids a long wait before learning that a path was mistyped. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously only extra_file1 through extra_file5 were read, so a sixth forcing file was silently ignored. Replace the five hard-coded names with a helper that collects any extra_fileN option from the config section, sorted by N, so an arbitrary number of extra files can be interpolated.
Also validate the extra_fileN paths (existence, and that interp_method is ncremap) before doing any of the expensive culling/mapping work, instead of only checking right before each file is remapped at the end of the step. This avoids a long wait before learning that a path was mistyped.
Checklist
api.rst) has any new or modified class, method and/or functions listedTestingin this PR) any testing that was used to verify the changes