chore: stop dependabot reopening majors blocked by peer deps - #11
Open
razbroc wants to merge 1 commit into
Open
Conversation
express 5 and typescript 7 both fail npm ci with ERESOLVE before any job runs, so dependabot reopens an unmergeable PR every week. express 5 is gated on @map-colonies/openapi-express-types@0.2.0, whose only published version peers @types/express@^4.17.21. typescript 7 is gated on openapi-typescript, which peers typescript@^5.x. Ignore the majors on both until the shared packages move.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to closing #1 (express 5) and #3 (typescript 7).
Both fail
npm ciwith ERESOLVE before any job runs, so every check on them is collateral from the failed install. Without an ignore rule dependabot reopens the same unmergeable PR every week.expressmajor — gated on@map-colonies/openapi-express-types@0.2.0, whose only published version peers@types/express@^4.17.21@types/expressmajor — paired with the abovetypescriptmajor — TS 7 is the Go rewrite;openapi-typescriptpeerstypescript@^5.x, and the shared MapColonies configs have to move firstThe express and dev-dep rules live in separate
updatesblocks becauseexpressis a production dep while@types/expressandtypescriptare dev.Revisit when the shared packages publish compatible peer ranges.