chore: correct .nvmrc to v24 (MAPCO-11282) - #297
Merged
Conversation
.nvmrc pinned v12 while CI (publish.yaml, pull_request.yaml) runs 24.x, and
master already depends on @map-colonies/raster-shared@8.3.0-alpha.0 which
declares engines node>=24.
Consequence: `nvm use && npm ci` fails today on master with
npm ERR! notsup Unsupported engine for @map-colonies/raster-shared@8.3.0-alpha.0:
wanted {"node":">=24.0.0"} (current: {"node":"12.22.12"})
CI is unaffected (it sets node-version explicitly and never reads .nvmrc), so
this is a local-development fix only. The other five raster repos in the
MAPCO-11282 sweep are all already on v24 — mc-models was missed.
.nvmrc is not published (files: ["Schema/**/*"]), so there is no consumer impact.
CL-SHLOMIKONCHA
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.nvmrcpins v12, but CI runs 24.x andmasteralready depends onraster-shared@8.3.0-alpha.0, which declaresengines: node>=24.So
nvm use && npm cifails on master today:CI is unaffected — the workflows set
node-versionexplicitly and never read.nvmrc. This is a local-development fix only.The other five raster repos (overseer, job-tracker, ingestion-trigger, polygon-parts-worker, polygon-parts-manager) are all on
v24already; mc-models was missed.No consumer impact —
.nvmrcisn't published (files: ["Schema/**/*"]).Unblocks local review of #296.