Repository navigation
fix: improve contrast of selected reaction in feedback widget - #12408
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
🟢 Approval recommended
The change is a small CSS-only value swap that uses theme tokens already defined in both themes and a color-mix pattern already used in the codebase, with the required changelog fragment included.
No open issues 🎉
What changed in this PR
This PR improves the contrast of the selected reaction button in the quick feedback widget. The old selected background (var(--bg-surface)) was too close to the popover background (var(--bg-elevated)), so users could not easily see which reaction they had picked. The selected and hover backgrounds now use color-mix(in srgb, var(--ink) 10%, var(--bg-elevated)), which gives a clearer highlight in both light and dark themes.
Changes:
- Replaces the selected-state background of the reaction toggle buttons with a stronger
color-mixvalue. - Applies the same value to the hover state, so hover matches the selected state.
- Adds a
changelog.d/fragment under### Fixedfor the change.
| File | Description |
|---|---|
| changelog.d/feedback-widget-contrast.md | Adds the required changelog fragment under ### Fixed, using the bold-titled bullet format. |
| app/src/components/FeedbackWidget.tsx | Swaps the selected and hover background of the reaction toggle buttons to the stronger color-mix value. |
Review effort: Lite
The user reported that it was hard to tell which reaction was selected in the quick feedback form. This was because the active background color
var(--bg-surface)was too similar to the popup's backgroundvar(--bg-elevated).This change modifies the
&.Mui-selectedstate of the toggle buttons to use a stronger contrast:color-mix(in srgb, var(--ink) 10%, var(--bg-elevated)). Now it clearly stands out when selected.PR created automatically by Jules for task 4922700295728149811 started by @MarkusNeusinger