Repository navigation
fix(nav): Keep debug navigation for >5 clicks - #12409
Conversation
…rapid clicks to route to debug.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are identified, and the change addresses repeated threshold clicks with targeted regression coverage.
No open issues 🎉
What changed in this PR
This pull request fixes rapid logo-click navigation so the fifth and subsequent clicks within the active 800 ms window continue navigating to /debug instead of returning home.
Changes:
- Preserves the click counter and timeout after reaching the debug threshold.
- Adds regression coverage for the fifth and sixth rapid clicks.
- Documents the fix in a changelog fragment.
| File | Description |
|---|---|
changelog.d/navbar-debug-click-fix.md |
Documents the navigation fix. |
app/src/layouts/NavBar.tsx |
Keeps debug navigation active for clicks at or above the threshold during the rapid-click window. |
app/src/layouts/NavBar.test.tsx |
Verifies that both the fifth and sixth rapid clicks navigate to /debug. |
Review effort: Lite
Fixes an issue where a 6th rapid click on the logo navigated to home instead of debug.
When clicking the logo 5 times, it navigates to debug. However, if a user accidentally clicked a 6th time, the counter was reset on the 5th click, and the 6th click would be treated as the 1st click, navigating to home.
This removes the counter reset inside the >5 clicks block so clicks >= 5 will all navigate to debug. The counter correctly resets naturally after the time window passes.
PR created automatically by Jules for task 5928450694688457251 started by @MarkusNeusinger