fix: substitute forward slash, not backslash, when encoding base64url - #104
Open
mmorales-post wants to merge 1 commit into
Open
fix: substitute forward slash, not backslash, when encoding base64url#104mmorales-post wants to merge 1 commit into
mmorales-post wants to merge 1 commit into
Conversation
mmorales-post
marked this pull request as ready for review
August 24, 2026 19:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
masterbranchLink to issue/feature request: #103
Description
toEncodedStringsubstituted\instead of/when converting base64 to base64url, soforward slashes were left unescaped in every JWE segment. This changes the regex to
/\//g.Both the current and corrected encodings decode successfully, so this is backward
compatible.
Two tests added to
test/jwe-crypto.test.js:#encryptData()asserts every segment of 25 generated tokens matches^[A-Za-z0-9_-]+$.The loop keeps the assertion independent of the random content encryption key and IV.
#toEncodedString()covers the substitution directly throughrewire, including that anon base64url target format is left untouched.
Both fail on
mainand pass with the fix. Full suite: 192 passing.Validated on Node 24.