Repository navigation
fix(deps): clear the open dependency security alerts - #246
Merged
Merged
Conversation
node-static is unmaintained and has open directory traversal and DoS advisories (GHSA-5g97-whc9-8g7j, GHSA-8r4g-cg4m-x23c) with no fix. It also pulled in optimist and a vulnerable minimist. Replace it with a small static file handler in test/utils.ts and drop the unused legacy takeScreenshot.js script that was the only other user. Also bump puppeteer to 25 (extract-zip, basic-ftp, zod advisories) and @typescript-eslint to 7.18 (minimatch ReDoS advisories).
The publish step bumped each package's own version but left the ranges between the packages at ^4.6.1, so installing @matdata/yasgui 6.x pulls in @matdata/yasqe and @matdata/yasr 4.8.0 from npm. Those old packages still depend on query-string 6 and an old dompurify, which raises Dependabot alerts in every project that depends on @matdata/yasgui.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Mathias · project thread
Closes #245. After this,
npm auditreports 0 vulnerabilities in the root and inwebsite/.Changes
build/with a ~30-line static handler intest/utils.ts(MIME types,index.htmlfor directories, refuses paths outside the build dir). Removes node-static, optimist and minimist@0.0.10. Deleted the unusedpackages/yasr/src/bin/takeScreenshot.js(Triply leftover, not referenced anywhere).^3.4.17in utils, yasgui and yasr, with a patch changeset.@matdata/*packages to^<version>. Today@matdata/yasgui@6.11.0depends on@matdata/yasqe@^4.6.1, which resolves to the old 4.8.0 from npm withquery-string6, so every plugin repo getsdecode-uri-componentalerts. Tried the script locally on copies of the package files with 6.12.0: yasgui → yasqe/yasr/utils^6.12.0, external deps untouched.Testing
npm run buildOKnpm run puppeteer-test: 78 passing (cloud run on another port, with the Playwright Chromium)npm run unit-test: 1754 passingnpx eslintonpackages/*/srcandtest/utils.ts: clean. (npm run util:lintalready fails onmainbecausepackages/*/testdoesn't exist.)Generated by Claude Code