Repository navigation
Keep the plug-in directly in plugin/ - #9
Merged
Merged
Conversation
A suite of one plug-in keeps it in plugin/, without a folder named by its id: the plug-in's sources, tests, tools, null tests and documents move from plugins/ChanSampler/ to plugin/, the measured data from measurements/ChanSampler/ to measurements/ and the regression cases and goldens from tests/regress/ChanSampler/ to tests/regress/. The folder name states the shape: plugin/ holds one plug-in, plugins/<Id>/ one of several. Every path that names a moved file follows, the null tests' path module included, and the starter's scripts, which tell the two shapes apart by the folder, are brought in. The targets, the build outputs, the screenshot names and the frozen identity are unchanged; the renderer's output is bit-identical. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the plug-in directly in plugin/
A suite of one plug-in keeps it in
plugin/(singular), without a folder named by its id; the folder name states the shape (plugins/<Id>/is a suite of several). Nothing user-facing changes, so the CHANGELOG has no line.What moves
plugins/ChanSampler/(plugin.cmake,Source/,tests/,tools/,nulltest/, the four documents)plugin/measurements/ChanSampler/*measurements/*tests/regress/ChanSampler/*(jobs.txt,golden/)tests/regress/*194 files are renames; 19 files change in place.
What follows the move
include()line inCMakeLists.txt,.provenance,.gitignore,README.md,CONTRIBUTING.md,docs/BUILDING.md, the issue contact link,requirements.txt, and the comments in the plug-in's sources and scripts.plugin/nulltest/paths_lib.py: the repository root is two levels up and the measured data ismeasurements/.check.ps1,check.sh,check_repo.py,render_regress.py,bump_version.py,make_site.py,build_native.py),STANDARDS.md, the release checklist andtests/regress/README.md; two comments intools/HostTest.cppandtools/Snapshot.cpptake the starter's wording.What stays
The targets,
packaging/plugins.txt,build/ChanSampler_artefacts/,build/plugins/, the screenshot names, thelocal.yamlkeys, the codes, class IDs and parameter IDs.Proof (Windows, the build folder removed first)
scripts/check.ps1 -KeepFlmoduleinfo.json(class IDs)plugin/nulltest/paths_lib.pymeasurements/(28 entries), the renderer and the signals folder resolve; all 90 Python scripts compilegit grepforplugins/ChanSampler,measurements/ChanSampler,tests/regress/ChanSamplerCHANGELOG.mdgit grep "plugins/"outsideCHANGELOG.mdbuild/plugins/, 21 are the standard's statements aboutplugins/<Id>/inSTANDARDS.mdand the starter's scriptsscripts/check_repo.py --releasecheck_consistency.py --public --historysync_template.py --check --shape singleThe null tests that render through FL Studio were not run.
After the merge, on a checkout that has local files
Git-ignored files do not move with the commit. Move by hand, from
plugins/ChanSampler/nulltest/toplugin/nulltest/:renders/,renders_fl/,ours/,probe/,local/,fst/,signals/(the generated.wavfiles),plugin_ref.flp/,fmt_test.flac,fmt_test.mp3,fmt_test.ogg,syn_*.wavand anyresults*.json; then delete the emptiedplugins/,measurements/ChanSampler/andtests/regress/ChanSampler/. Configure in a fresh build folder, or deletebuild/CMakeCache.txtfirst: the include path changed. The DAW junction onbuild/pluginsis unchanged.🤖 Generated with Claude Code