Repository navigation
Document the shared temporal-leakage checks for run_e2e - #52
Draft
florian6973 wants to merge 1 commit into
Draft
florian6973 wants to merge 1 commit into
florian6973 wants to merge 1 commit into
Conversation
…nd testing guide run_e2e is rerun on a copy with every evaluated future rewritten (bit-identical predictions required) and called with a null_world dataset (chance-level AUROC required); both come from meds_algorithm.conformance.temporal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to McDermottHealthAI/meds-algorithm#21, which adds
conformance/temporal.py. That PR adds two checks:Changes:
template/tests/e2e.pyrun_e2edocstring now states both obligations: honour a perturbedexternal_meds_dir, and run thenull_worlddataset with small offline test settings.template/docs/TESTING.mdexplains what the shared checks cover and what algorithm-specific tests are still needed (internal invariance of inputs and states at T).This PR changes documentation only. The 18 Windows failures in
tests/test_render.pyalso occur onmain.🤖 Generated with Claude Code