Repository navigation
RX1: don't flag Atlas_Core's stock theme-folder import as a FILES-route risk - #12
Merged
Merged
Conversation
…te risk An audit on a real 10.24 to 11.12 run read Atlas_Core's own "@import ../../../theme/web/custom-variables" as a hand-edited vendor file at FILES-route risk. The same line is Mendix's own module-template boilerplate, present identically in 46 of the app's 52 themesource modules, including modules the audit had already confirmed carried no other edits. An Atlas_Core update regenerates it every time; it's not what an update wipes. Add bin/scss_boilerplate_check.py: classifies an outward theme/web/ import as BOILERPLATE (custom-variables / exclusion-variables: stock, no route needed) or RISK (anything else: a real app edit, route it FILES same as before). Catch and pass case wired into controls/run-controls.sh. Second lesson from the same audit (RX1-2): it read HTMLSnippet as still on 3.9.9 from an archived run's decision log, but the real delivered .mpk had already migrated every instance to Events + a bridge nanoflow / native HTML element. Note added to playbooks/widgets.md: judge widget-version claims from the shipped model, not an archived decision trail. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@import "../../../theme/web/custom-variables"/exclusion-variableslines as a hand-edited vendor file at FILES-route risk. The same two lines are Mendix's own module-template boilerplate, present identically in 46 of the app's 52 themesource modules, including modules already confirmed to carry no other edits — an Atlas_Core update regenerates them every time.bin/scss_boilerplate_check.py: given a themesource module, classifies each outwardtheme/web/import asBOILERPLATE(the two stock names, no route needed) orRISK(anything else: a real app edit, still routed FILES as before). Catch + pass case wired intocontrols/run-controls.shasscss-boilerplate-pass/scss-boilerplate-app-edit-risk-catch..mpkhad already migrated every instance to Events widget + a bridge nanoflow / native HTML element. Added a caution toplaybooks/widgets.md's HTMLSnippet section: judge widget-version claims from the shipped model, not an archived decision trail.FEEDBACK.md: newRX1glossary entry, rows RX1-1/RX1-2, and the running counts table updated (686 -> 688 rows).Test plan
bin/scss_boilerplate_check.pyrun directly against a synthetic pass-case module (only the two stock imports) and a catch-case module (stock imports + one app-specific outward import): exit 0 / exit 1 respectively, correct BOILERPLATE/RISK lines.controls/scss_boilerplate_control.sh passand... catchrun standalone, output matches thectllines added torun-controls.sh.run-controls.shsuite not run end-to-end in this PR (it has slow/interactive fixtures unrelated to this change); the two newctllines were verified by running the control script directly and checking its output against the exact regexes used.customer_names_check.sh-style manual grep and the secret-pattern scan run against every changed/new file: clean.No app code, customer name, or real app name appears anywhere in this PR (code name RX1 used throughout, per CONTRIBUTING.md).
🤖 Generated with Claude Code