Skip to content

afterwalk: the menu copy of a page is the same step; stop quotes only this run; mock keychain on every browser - #13

Merged
MendixMau merged 2 commits into
mainfrom
fix/afterwalk-menu-copy
Nov 17, 2026
Merged

MendixMau merged 2 commits into
mainfrom
fix/afterwalk-menu-copy

Conversation

@MendixMau

Copy link
Copy Markdown
Owner

From the cold test WM1 rerun on the merged toolkit: the walk passed 9 of 9, but the run stopped.

  • smokewalk.js: a menu entry that now opens the app's copy of the page (same document name, other module) is the same step, not "step gone" plus "new step". WM1 re-judged: 9 PASS, 0 regressions, coverage lost 0
  • upgrade-pipeline.sh: the stop report quotes only the step-log lines of this run
  • every chromium.launch carries --use-mock-keychain --password-store=basic
  • triage: with no scanner configured the note names what is missing
  • 4 new controls; full suite on macOS 2653 passed, 1 timing flake (passes alone)

🤖 Generated with Claude Code

MendixMau and others added 2 commits November 17, 2026 17:21
…ly this run; every browser gets the mock keychain

Cold test WM1 rerun on f7ed981: the walk passed 9 of 9, but the Accounts menu entry now opens the app's copy of the page, so the
compare saw "step gone" (coverage lost, exit 2) plus "new step", and the stop report quoted a failed walk from an earlier run.
- smokewalk.js: a menu step whose page has the same document name in another module is judged as the same step ("moved")
- upgrade-pipeline.sh: nj_file quotes only the lines of the step log written by this run (LOG_START)
- every chromium.launch in bin, controls, vendor and research carries --use-mock-keychain --password-store=basic
- controls: smoke-judge-menu-copy-same-step-pass, smoke-judge-other-page-gone-catch, pipeline-nj-quotes-this-run-pass,
  browser-launch-mock-keychain-pass

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Cold CMM: triage noted "scanner not available at : scanner rung INVALID", an empty
path. Now "scanner not configured (EA, UPG_SCANNER, or UPG_SCANNER= in
~/.config/upgrade-toolkit/local.env)" when nothing is set, and "scanner not found at
<path> (no scripts/scan.py)" when a path is set but holds no scanner. Controls:
pipeline-scanner-not-configured-catch, pipeline-scanner-not-found-catch.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@MendixMau
MendixMau merged commit 8404659 into main Nov 17, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant