Skip to content

E2E-R1: rendered check, a pluggable widget drawn and not only in the DOM - #8

Merged
MendixMau merged 3 commits into
mainfrom
e2e/rendered-widget-check
Nov 17, 2026
Merged

MendixMau merged 3 commits into
mainfrom
e2e/rendered-widget-check

Conversation

@MendixMau

Copy link
Copy Markdown
Owner

Why

On FSM 11.12.7 with Ultimate Scheduler 1.4.0 the scheduler page opened and every journey guard held, so the run was green. But the widget was only a header over a 0 px rows area. Guards only prove that a page opened, not that a widget drew.

What

  • bin/widgetrender.js: checks that a widget is drawn, not just present in the DOM. It FAILs on any of:

    • a size of 0
    • no drawn content
    • the client's "Could not render widget" text
    • a missing or collapsed part
    • a client error from the widget's own script

    A PASS needs a still widget: nothing loading, and two looks 1 s apart that match. It works as a CLI or as a library.

  • playbooks/widget-render.tsv: per-widget parts, so far 3 rows for the scheduler (both 1.4.0 and 3.8.0 root classes).

  • New journey verb {"do": "rendered", "widget": "...", "data": true}, wired through run_journeys.py. It copies the engine files, records client errors from the first page, and adds the act and describe cases.

  • steps/journeys.md: the guard note now points to the verb.

Proof

Build Check on its own Through run_journeys
Pre-fix (Ultimate Scheduler 1.4.0) FAIL 3/3 (rows area 0 px tall, or "Could not render widget", plus a setTimeSpan error) 0/1 PASS
Fixed (3.8.0) PASS 3/3 (rows area 2/2, rows 8/8, events 4/4) 1/1 PASS

private_names.sh, private_hosts.sh and customer_names_check.sh all pass.

🤖 Generated with Claude Code

https://claude.ai/code/session_01HXpQSjPfSUmbjM87Luyq27

MendixMau and others added 3 commits November 16, 2026 10:20
On FSM 11.12.7 with Ultimate Scheduler 1.4.0 the scheduler page opened and every
guard held, but the widget was a header over a 0 px rows area. The new check
fails that: size, drawn content, the client's "Could not render widget" text,
per-widget parts from playbooks/widget-render.tsv, and client errors from the
widget's own script. A PASS needs a still widget (two looks alike, nothing loading).

Pre-fix build FAIL 3/3, the 3.8.0 build PASS 3/3 (rows 8/8, events 4/4);
through run_journeys: pre 0/1 PASS, fixed 1/1 PASS.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HXpQSjPfSUmbjM87Luyq27
…unt as flat, widgetrender control

- widgetrender.js: check() counts only errors logged after the step started
- widgetrender.js: a part is flat when not shown or under 1 px tall (0x0 and display:none no longer pass h>0)
- widgetrender.js: timeoutMs also from WIDGETRENDER_TIMEOUT_MS
- controls/widgetrender_control.js + fixtures/widgetrender: broken, display:none and fixed pages (a minimal reconstruction of the Bryntum grid classes, not a captured page), wired as journeys-rendered-catch / -pass

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HXpQSjPfSUmbjM87Luyq27
…0 px, so the selftest fails when the !shown flat rule is reverted

Review: MERGE-AFTER-FIX: display:none has a 0 px box, so the old height test already passed it.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HXpQSjPfSUmbjM87Luyq27
@MendixMau

Copy link
Copy Markdown
Owner Author

Review fixes pushed (c447116, a78ab2f): client errors scoped to the step, hidden parts count as flat, and the hidden-part fixture is now visibility:hidden at 200 px so the selftest fails when that rule is reverted.

Review: MERGE — fresh re-review: selftest 7/7, fix 2 reverted gives 6/7 (case fails), run-controls --only journeys-rendered 2/2, merge with main clean.

🤖 Generated with Claude Code

https://claude.ai/code/session_01HXpQSjPfSUmbjM87Luyq27

@MendixMau
MendixMau merged commit 9e7e52d into main Nov 17, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant