Repository navigation
E2E-R1: rendered check, a pluggable widget drawn and not only in the DOM - #8
Merged
Merged
Conversation
On FSM 11.12.7 with Ultimate Scheduler 1.4.0 the scheduler page opened and every guard held, but the widget was a header over a 0 px rows area. The new check fails that: size, drawn content, the client's "Could not render widget" text, per-widget parts from playbooks/widget-render.tsv, and client errors from the widget's own script. A PASS needs a still widget (two looks alike, nothing loading). Pre-fix build FAIL 3/3, the 3.8.0 build PASS 3/3 (rows 8/8, events 4/4); through run_journeys: pre 0/1 PASS, fixed 1/1 PASS. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HXpQSjPfSUmbjM87Luyq27
…unt as flat, widgetrender control - widgetrender.js: check() counts only errors logged after the step started - widgetrender.js: a part is flat when not shown or under 1 px tall (0x0 and display:none no longer pass h>0) - widgetrender.js: timeoutMs also from WIDGETRENDER_TIMEOUT_MS - controls/widgetrender_control.js + fixtures/widgetrender: broken, display:none and fixed pages (a minimal reconstruction of the Bryntum grid classes, not a captured page), wired as journeys-rendered-catch / -pass Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HXpQSjPfSUmbjM87Luyq27
…0 px, so the selftest fails when the !shown flat rule is reverted Review: MERGE-AFTER-FIX: display:none has a 0 px box, so the old height test already passed it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HXpQSjPfSUmbjM87Luyq27
Owner
Author
|
Review fixes pushed (c447116, a78ab2f): client errors scoped to the step, hidden parts count as flat, and the hidden-part fixture is now visibility:hidden at 200 px so the selftest fails when that rule is reverted. Review: MERGE — fresh re-review: selftest 7/7, fix 2 reverted gives 6/7 (case fails), run-controls --only journeys-rendered 2/2, merge with main clean. 🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
On FSM 11.12.7 with Ultimate Scheduler 1.4.0 the scheduler page opened and every journey guard held, so the run was green. But the widget was only a header over a 0 px rows area. Guards only prove that a page opened, not that a widget drew.
What
bin/widgetrender.js: checks that a widget is drawn, not just present in the DOM. It FAILs on any of:A PASS needs a still widget: nothing loading, and two looks 1 s apart that match. It works as a CLI or as a library.
playbooks/widget-render.tsv: per-widget parts, so far 3 rows for the scheduler (both 1.4.0 and 3.8.0 root classes).New journey verb
{"do": "rendered", "widget": "...", "data": true}, wired throughrun_journeys.py. It copies the engine files, records client errors from the first page, and adds the act and describe cases.steps/journeys.md: the guard note now points to the verb.Proof
private_names.sh,private_hosts.shandcustomer_names_check.shall pass.🤖 Generated with Claude Code
https://claude.ai/code/session_01HXpQSjPfSUmbjM87Luyq27