Repository navigation
fix(obligations): quality floor — per-module passes owed by what was built; one must-have list for every build type - #787
Merged
Conversation
…built, not only by what was planned; must-haves list for every build type With no module brief and no verify run, every per-module obligation (look, fidelity, sweep, journeys) printed "PASS — nothing owed", even on a project that had built ~78 pages and reviewed 0 (field run, requirements-driven, stages 1-4 skipped). An empty planned scope now falls back to the modules that hold built pages (look ledger, else *.mdl page statements, else page-scope.json; root, app/, apps/*/), with a denominator line. A .mpr whose pages cannot be counted is one FAULT naming page-scope.sh. Projects with briefs keep every earlier verdict. skills/must-haves.md is the single source of poc-build.md's must-have checklist, generalised to every build type plus a design-regions row; module-review.md stage 5 requires its mark, and obligations.tsv owes it per module. Baseline words 64,984 -> 65,032 (budget 80,000). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HXpQShKoiXaG1kwz64TtJ8
…haves/<Module>.md .claude/loop/ is git-ignored, so a mark there is invisible to CI, to reviewers and to a fresh clone, which is how the field run's look ledger stayed hidden. Line 1 is unchanged: "13 of 13 rows ticked or NOT DONE with a reason". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HXpQShKoiXaG1kwz64TtJ8
…e 5 when the row arrived sync-project.sh writes one Must-haves: line when none exists: advisory if the derived Current stage or Adopted at stage is 6/7, else bound; init-project.sh writes bound. An advisory project's must-haves row reads ADVISORY and is not counted as pending. Keyed on the written line, never on position, so a new project cannot go quiet by passing Stage 5 without the marks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HXpQShKoiXaG1kwz64TtJ8
4 of 6 tasks
…rtifact-manifest.tsv Column 10 `modes` uses the manifest's tokens and entry_mode_token. A row the declared Entry mode does not list reads "N/A — not owed (entry mode ...)", never PASS; no or unrecognised mode means owed. Every row lists all four modes today, so no verdict changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HXpQShKoiXaG1kwz64TtJ8
MendixMau
pushed a commit
that referenced
this pull request
Nov 17, 2026
…wn axis Per the vocabulary correction: artifact-manifest.tsv column 6 keeps migration,requirements,greenfield,existing-app-change (the tokens entry_mode_token produces, copied by obligations.tsv column 10 in #787). No poc or all token; Build type: poc is read by gate-check.sh only. Only the N/A wording changes ("not owed (mode ...)"). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HXpQSifRwo7EWWDP1hPps8
…t_entry_mode obligation-check carried its own copy of the requirements-driven -> requirements translation. It now calls the one artifact-check.sh uses, so the two tables cannot drift apart. Fixture T9 adds: Entry mode requirements-driven, a row omitting requirements is not owed; a row listing it is owed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HXpQShKoiXaG1kwz64TtJ8
…page-scope scope for existing-app-change Review of #787: a fresh scaffold with a .mpr read FAULT on six rows, and status.sh's "modules opened: 0" became "≥1". The FAULT now needs build evidence (BUILD-LOG exec rows, *.mdl scripts, or a derived stage at 5+); a .mpr alone keeps master's PASS line. existing-app-change never takes scope from page-scope.json, which lists the whole model. The entry-mode check now runs after the stage limit. sync-project.sh's comment states that the stage is the last gate-check stamp. Fixture T5/T6/T6b updated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HXpQShKoiXaG1kwz64TtJ8
6 of 7 tasks
MendixMau
added a commit
that referenced
this pull request
Nov 17, 2026
…n rule, design front end (#790) With no declared entry mode or adoption, every exec.sh run, status.sh and the gate-check summary print one warn-only banner: the toolkit treats the project as Stage P, not started. In migration and requirements-driven projects, the first MDL write with no plan evidence is refused once per clone, before any lock, snapshot or write. It clears with an adoption at stage 5 or later, a reasoned stage-4 waiver (including the aggregate `Waived stages: … 4 — reason`), a Stage 5+ readout, or a build plan plus a brief. Never refused: a-la-carte (new), poc, existing-app, --patch and undeclared projects. Documentation adds the greenfield design front end (poc-build steps 1–4) and mapping a supplied prototype as the wireframe (design-artifacts Step 2a; the ui-preflight STOP accepts it). project-bin/_position.sh is the shared, process-free tokeniser. Field evidence: two unattended requirements-driven field runs built about 78 pages with no plan while every guard stayed silent. Review: MERGE — refuse-once plan rule and banner verified (46/46, bug06 64/0, 0 process starts added); composes with #787 and #788 (65,373 words); CI red once on unrelated flaky test-app-restart.sh (mktemp suffix vs "zqx"), green on re-run Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MendixMau
added a commit
that referenced
this pull request
Nov 17, 2026
…ion check (#793) The composition check of #787/#788/#790/#791/#792 found three ways an unattended agent could still get past the plan gate. This closes them: - Auto detection uses one first-word rule (mxtk_auto_word in project-bin/_position.sh) shared by exec.sh, gate-check.sh's --adopt check and ready.sh. `Interview mode: auto (…)` and `unattended — …` now count as auto, and the strictest of env, state file and register wins. - ready.sh reports NOT READY while any `consentBy: auto-mode` adoption row is unconfirmed, so an agent cannot approve its own plan skip and reach READY. - Under auto, an undeclared Entry mode is refused before build-ready. Attended behaviour is unchanged. - The checkpoint skills no longer describe greenfield as a live mode. Review: MERGE — no findings (the H/K/W/U order fix restores test-mode-contract to 28/0; the strictest-wins change is now in the CHANGELOG; CI green on d3c4ced) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
MendixMau
added a commit
that referenced
this pull request
Nov 17, 2026
This is the output of bin/cut-release.sh. The 24 entries under `## Unreleased` become `## v2026.11.17`. Included: #787, #788, #790, #791, #792 and #793. #789 is held. Review: MERGE — no findings (CHANGELOG heading only; the release section has no client names; CI green on 072e417) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
1. No per-module obligation reads PASS by absence (
bin/lib/obligation-check.sh)._ob_modules()keys scope to module briefs and verify runs, which only exist if a project ran the planning stages. A project that skipped them gotPASS — nothing owedon look, fidelity, sweep and journeys. Now, only when the planned scope is empty, the scope falls back to the modules that hold built pages. The first source that yields pages wins:.claude/loop/look/owed.tsv(col 3)*.mdlscripts. This uses the same CREATE/ALTER/DROP shapes aslook_pages_in(), skips*.test.mdl, and prunesdeployment/,.git,node_modulesand similar.claude/loop/page-scope.jsoninScope(never forexisting-app-change)Each source is looked for at
<root>,app/andapps/*/. No mxcli call is made. Every module row then reads PENDING, plus a denominator line:OWED BY WHAT WAS BUILT: N page(s) built in M module(s) (A 2, B 1), K of M module(s) discharged — … (source: …).bin/page-scope.sh. "Built on" means BUILD-LOG exec rows,*.mdlscripts, or a derived stage of 5 or later. It never reads as "0 pages"..mpr) → master's PASS line, unchanged.2. One must-have list for every build type (
skills/must-haves.md, new, on demand, verify group).This is
poc-build.md's 12-row checklist made generic, plus row 13: every region the design shows is on the built page, counted K of K. That row targets the missing dashboard tiles, status tiles and side navigation from the field run.poc-build.mdnow points to the list instead of keeping its own copy.module-review.mdstage 5 requires the markdocs/progress/must-haves/<Module>.md, whose first line is13 of 13 rows ticked or NOT DONE with a reason. The path is tracked on purpose:.claude/loop/is git-ignored.bin/ready.sh(T3) reads the same path.must-haves(module scope, denominator yes, from stage 5). The fallback above applies to it too.3.
Must-haves: bound | advisory, decided once per project (commit cfffffd).init-project.shwritesMust-haves: boundfor new projects.sync-project.shwrites oneMust-haves:line whenPROJECT.mdhas none, and only then:advisory — joined at stage N before the must-haves row existed, when the last Current stage line gate-check stamped reads 6 or 7, orAdopted at stage:is 6 or 7;bound.bound.ADVISORY — K of N discharged; NOT DONE: …, keeps the module list visible, and is not counted as pending. On a scratch project the pending count was 10 with advisory and 11 with bound.Adopted at stage:line) getsbound. Its owner edits the line toMust-haves: advisory — <reason>; the sync message says so.--adoptis too broad.4. Entry-mode column on
obligations.tsv(commits 9de09b5 and b750ff3).modes, the same column and tokens asartifact-manifest.tsvcolumn 6:migration,requirements,greenfield,existing-app-change.artifact-check.sh's own_art_entry_mode. It is called, never copied.N/A — not owed (entry mode …; row modes: …), never PASS.Build type: pocis not an entry mode.Entry mode: a-la-carteis unknown to master's tokeniser, so it reads as owed. T2's process(entry modes): retire greenfield — two doors, sync mapping (stacked on #791) #792 adds the tokens.5. Fixtures
tests/wave2/test-obligation-quality-floor.shcovers:apps/<App>/layout with page scripts and no briefs;tests/wave2/test-must-haves-advisory.shcovers bound and advisory as written by init and sync, the second sync being a no-op, and the pending count.What changes for existing projects after
sync-project.shPROJECT.mdline, written once:Must-haves: advisory — …if past Stage 5 (stamped or adopted 6/7), elseMust-haves: bound.docs/progress/must-haves/<Module>.md, or with--waive must-haves/<Module> --reason "…".PASS — nothing owedto PENDING on look, sweep, journeys, fidelity and dispatch. That is the fix..mprand no build evidence: unchanged (master's PASS line;status.shmodules opened: 0).Field evidence
Two field runs (Nov 2026, unattended, requirements-driven, prototypes and design system supplied, several apps under
apps/<App>/). Planning stages were skipped, ~78 pages were built and 0 reviewed, andgate-check.sh <copy> 5printedObligation look PASS — no module has been opened for work yet; nothing owed(same for fidelity).Field run (CLAUDE.md "Shipping an instrument", rule 4)
The maintainer ran
bin/gate-check.sh <copy> 5at 642d1db on a real copy of the field repo: six apps underapps/<App>/, no briefs, no build plan, tracked files only.PASS — no module has been opened for work yet; nothing owed.PENDING — 0 of 6 discharged, withOWED BY WHAT WAS BUILT: 78 page(s) built in 6 module(s) (…), 0 of 6 module(s) discharged (source: page statements in *.mdl scripts).The later commits keep that path. Pages counted from
*.mdlengage the floor exactly as before, and the field copy has noEntry mode:line.Verdicts, before → after (scratch copies,
MXTK_ROWS_UPTO=5)OWED BY WHAT WAS BUILT: 4 page(s) built in 3 module(s)….mpr.mpr+ BUILD-LOG exec rows, no countable pagesbin/page-scope.sh.mpr+ page-scope.json, no briefs/scriptsRegression risk
obligations.tsvwent from 9 to 10 columns. Every in-repo reader usesNF>=9or columns ≤ 9. A 9-column row reads as owed by every mode.obligation-check.shsourcesbin/lib/artifact-check.sh, which only defines functions and whichgate-check.shalready sources.mxtk_appsin_ob_built_pages.grepover BUILD-LOG only on the no-pages path.check-portability.shis clean.Field-proof gaps (stated honestly)
exec.sh'slog_buildrow format but is not captured output.init-project.shscaffold +status.sh: T5, T6, T6b, T9'srequirements-drivencases.Earlier work
No open PR covered "LOOK/fidelity passing by absence".
claude/first-build-page-quality-3f6d7vshares no merge base with master. This PR is independent.Word budget
bin/render-routing.sh --check: baseline 64,984 → 65,032 (+48, budget 80,000; later commits add no skill text). The added text is themodule-review.mdstage 5 paragraph, needed at module close.Not touched (other sessions):
project-bin/exec.sh,bin/status.sh, the runbook and entry-mode rules,bin/ready.sh,bin/lib/_common.sh,bin/lib/entry-mode.sh,bin/lib/artifact-check.sh.sync-project.shandinit-project.shget one block or line each, for the Must-haves line.Do not merge without the independent review (CLAUDE.md "Merging a PR").
🤖 Generated with Claude Code
https://claude.ai/code/session_01HXpQShKoiXaG1kwz64TtJ8