Skip to content

fix(exec, ready, gate-check): unattended read by first word; ✋ adoption blocks READY; undeclared + auto refused - #793

Merged
MendixMau merged 2 commits into
masterfrom
claude/auto-mode-hardening
Nov 17, 2026
Merged

MendixMau merged 2 commits into
masterfrom
claude/auto-mode-hardening

Conversation

@MendixMau

Copy link
Copy Markdown
Owner

Direct lane

What changed and why (one paragraph): The composition check on master 1fbd5c0 (after #790–#792) returned COMPOSES-AFTER-FIX with three holes in the unattended path. This PR closes them.

  1. Auto by first word, through one helper. mxtk_auto_word in project-bin/_position.sh is now the only place that decides whether an Interview mode value means unattended: first word auto or unattended, any case, with emphasis, backticks and trailing text ignored.
    • Before this, _position.sh (used by exec.sh) and gate-check.sh --adopt's ✋ check read the exact value. Interview mode: auto (gate questions go to questions.md …) was read as attended. In a field smoke run, the second write of an unattended build passed the plan rule on refuse-once.
    • ready.sh already used the first-word rule; it now calls the same helper (through the bin/lib/entry-mode.sh shim), so the three readers can't drift.
    • Strictest reading wins in exec.sh: env, .claude/.interview-mode, or the register line.
  2. An agent can't approve its own skipped plan. Under auto, --adopt 5 clears exec.sh's refusal, CI check (d) and ready.sh's position row. Its ✋ row (consentBy: auto-mode) only failed Stage 6, and ready.sh runs gate 6 only once the register reaches Stage 6. ready.sh now reports NOT READY, in a new adoption row named in the evidence file, while any such row is unconfirmed. A person confirms by putting their name in consentBy. With none present, the row is n/a and doesn't change the K-of-N count.
  3. Undeclared + auto is refused. With no Entry mode: under auto, exec.sh now refuses every MDL write, the same way as requirements-driven, until build-ready passes or the project adopts. Attended is unchanged (banner only). The refusal logic is one shared function, so both cases use identical text.
  4. Optional text item. Checkpoint skills (cutover, extraction, scope) no longer describe greenfield as a live mode. Not changed: the comment line in templates/ci/toolkit-gates.yml. Editing that template would make every project that installed it since new(ready, ci): READY only via bin/ready.sh, evidence in git, and a CI gate an agent cannot skip #788 read as "differs from the toolkit template" at sync, for a comment-only change. Left for a later template revision.

What changes for existing projects after sync-project.sh:

  • Projects whose Interview mode line is auto (…), unattended — … or bolded now get the auto behaviour: every write held until build-ready, and a ✋ row on adoption.
  • Auto projects with no Entry mode are now refused instead of warned.
  • ready.sh on an auto project with an unconfirmed ✋ adoption is NOT READY.
  • Attended projects: no change.

Impact

Row Answer
Process New blocking path on auto + undeclared projects. New NOT READY condition when an unconfirmed ✋ auto-mode adoption exists.
Dependencies project-bin/_position.sh (installed; the shared tokeniser file), project-bin/exec.sh, bin/gate-check.sh, bin/ready.sh (now sources bin/lib/entry-mode.sh), three on-demand checkpoint skills.
Context cost none: baseline 65,568 → 65,568 words (budget 80,000), from bin/render-routing.sh --check on base and head. The checkpoint skills changed are on demand.
Behaviour n/a: scripts, plus on-demand skill text that only renames a mode in three table cells.
Runtime Time cost: per exec · 0 process starts added (mxtk_auto_word is builtins only) · can force rework: y (auto + undeclared projects must declare or adopt) · offset: none. ready.sh adds one grep pipeline per run.

Field evidence: the field smoke run quoted in the composition check (auto (…) read as attended; the second write passed). Manual runs here on a scratch project from a captured init-project.sh scaffold:

  • attended + undeclared → banner, write reaches check;

  • auto (…) + undeclared → refused, 0 check calls;

  • unattended — … + requirements-driven → refused on the first and second writes;

  • helper: 13 spellings checked, autopilot is not auto;

  • ready.sh's ✋ grep matches auto-mode adoption rows, bolded and backticked too, but not a row a person confirmed and not a non-adoption row.

  • No client data (check-no-client-data.sh clean)

  • Size cap: 9 files excluding CHANGELOG, small diff

  • Test tier: fixture cases added (test-mode-contract.sh W and U, test-ready.sh R4 adoption) but not executed by the builder: the permission classifier refuses fixture runs in this session. The reviewer should run entry-mode-plan-rule, mode-contract, ready, ci-gates and greenfield-retired. check-scripts.sh passes 144/144; check-portability.sh is clean (408 files); bash -n is clean on every changed script.

  • CHANGELOG.md line appended (baseline word count unchanged)

Do not merge before the independent review.


Generated by Claude Code

…on blocks READY; undeclared + auto refused

- mxtk_auto_word (project-bin/_position.sh): the one reading of an
  Interview mode value as unattended (first word auto/unattended), used by
  exec.sh's reader, gate-check.sh --adopt's ✋ check and ready.sh.
- ready.sh: NOT READY while a `consentBy: auto-mode` adoption row is
  unconfirmed (row `adoption`, in the evidence file).
- exec.sh: under auto, no Entry mode is refused like a pipeline mode until
  build-ready passes or the project adopts; attended keeps the banner only.
- checkpoint skills: greenfield no longer described as a live mode.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HXpQSifRwo7EWWDP1hPps8
…s); CHANGELOG notes the strictest-reading change

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HXpQSifRwo7EWWDP1hPps8
@MendixMau
MendixMau merged commit cd70dd7 into master Nov 17, 2026
2 checks passed
@MendixMau MendixMau mentioned this pull request Nov 17, 2026
MendixMau added a commit that referenced this pull request Nov 17, 2026
This is the output of bin/cut-release.sh. The 24 entries under `## Unreleased` become `## v2026.11.17`. Included: #787, #788, #790, #791, #792 and #793. #789 is held.

Review: MERGE — no findings (CHANGELOG heading only; the release section has no client names; CI green on 072e417)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants