Repository navigation
Validate the selected union member with serdevalid - #200
Open
EricLiu2000 wants to merge 1 commit into
Open
EricLiu2000 wants to merge 1 commit into
EricLiu2000 wants to merge 1 commit into
Conversation
This was referenced Oct 15, 2026
EricLiu2000
force-pushed
the
codex/validate-selected-union-member
branch
from
October 15, 2026 03:59
d632f3a to
f7dd843
Compare
Signed-off-by: Eric Liu <ericxliu@gmail.com>
EricLiu2000
force-pushed
the
codex/validate-selected-union-member
branch
from
October 15, 2026 04:18
f7dd843 to
9edf46b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #199.
With
serdevalidenabled,OneOfNandAnyOfNcurrently return success without checking their selected member. Replace the empty derived validation with a match that returns the selected member's validation result.The
Validatebounds apply to the trait implementation. The union types keep their existing bounds, so unions with primitive members still support serialization and deserialization.Validation:
cargo fmt -- --check,cargo test,cargo test --all-features,cargo clippy --all-targets -- -D warnings, andcargo clippy --all-targets --all-features -- -D warningspass. The new tests fail before the fix and cover both union kinds and primitive serialization.