Scrape events with invalid InSite URLs if they appear in the web calendar - #50
Merged
Conversation
hancush
commented
Jul 10, 2025
| LOGGER = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| class LAMetroAPIWebEventScraper(WebCalendarMixin, LegistarAPIEventScraper, Scraper): |
Collaborator
Author
There was a problem hiding this comment.
Since we're using this in the root scraper and the paired event stream, I broke it out into its own class.
hancush
commented
Jul 10, 2025
Comment on lines
+31
to
+32
| def _not_in_web_interface(self, api_event): | ||
| return api_event["EventBodyName"] == "OCEO Draft Review" |
Collaborator
Author
There was a problem hiding this comment.
This is always a private meeting.
hancush
commented
Jul 10, 2025
Comment on lines
+54
to
+58
| def LAMetroWebEvent(event_dict): | ||
| if "Meeting video" in event_dict: | ||
| return LAMetroWebEventDetail(event_dict) | ||
| else: | ||
| return LAMetroWebCalendarEvent(event_dict) |
Collaborator
Author
There was a problem hiding this comment.
There are slight differences between the event detail dict and the calendar listing dict. Use a factory to return the right dict subclass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
See title.
Closes #49
Connects opencivicdata/python-legistar-scraper#129
Notes
Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.
Testing Instructions