Skip to content

Let comment notifications through Rotur message settings - #79

Merged
Mistium merged 3 commits into
mainfrom
comment-notifications-not-messages
Nov 20, 2026
Merged

Mistium merged 3 commits into
mainfrom
comment-notifications-not-messages

Conversation

@Mistium

@Mistium Mistium commented Nov 20, 2026

Copy link
Copy Markdown
Member

Comment notifications (on projects, profiles, replies and mentions) never reached people whose Rotur "who can message me" is friends only. That's the default for Rotur accounts without a date of birth, so many older adult accounts are affected too. addNotification asked Rotur's message signal and dropped the notification on any refusal. "Who can message me" isn't "who can notify me".

  • addNotification no longer asks the message signal before posting to Rotur. Rotur now applies the rules itself for MistWarp's notifications about someone (rotur/api#243, deployed as 13.10.1): it ignores "who can message", silently drops the notification on a block either way or a parent's message limit, and drops actor mutes when storing it.
  • MistWarp's own blocks, mutes and shadow bans still run first, unchanged.
  • If Rotur can't take a notification (network error, refusal) and MistWarp would keep it locally, the message signal is still asked first. A local copy therefore never skips a block or a parent's limit. Classroom accounts stay local and aren't asked, as before.
  • isMessageNotification and roturMessageRefusal are removed. roturMessageAllowed is exported for the fallback.

Tests: new src/community/notifications.test.osl runs addNotification against a fake Rotur. It covers delivery despite a message refusal, a MistWarp block, the fallback with a refused and an allowed signal, and classroom accounts. The fallback case fails without the fix. osl test (62 passed), osl lsp check, compile, conventions and the smoke test all pass on the CI-pinned OSL.

Version: 1.1.0 -> 1.1.1. No visible UI change, so there are no screenshots.

@Mistium
Mistium merged commit aa9b012 into main Nov 20, 2026
1 check passed
@Mistium
Mistium deleted the comment-notifications-not-messages branch November 20, 2026 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant