Repository navigation
Let comment notifications through Rotur message settings - #79
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment notifications (on projects, profiles, replies and mentions) never reached people whose Rotur "who can message me" is friends only. That's the default for Rotur accounts without a date of birth, so many older adult accounts are affected too.
addNotificationasked Rotur's message signal and dropped the notification on any refusal. "Who can message me" isn't "who can notify me".addNotificationno longer asks the message signal before posting to Rotur. Rotur now applies the rules itself for MistWarp's notifications about someone (rotur/api#243, deployed as 13.10.1): it ignores "who can message", silently drops the notification on a block either way or a parent's message limit, and drops actor mutes when storing it.isMessageNotificationandroturMessageRefusalare removed.roturMessageAllowedis exported for the fallback.Tests: new
src/community/notifications.test.oslrunsaddNotificationagainst a fake Rotur. It covers delivery despite a message refusal, a MistWarp block, the fallback with a refused and an allowed signal, and classroom accounts. The fallback case fails without the fix.osl test(62 passed),osl lsp check, compile, conventions and the smoke test all pass on the CI-pinned OSL.Version: 1.1.0 -> 1.1.1. No visible UI change, so there are no screenshots.