Repository navigation
Add last-commits inspection for per-path latest changes - #82
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
GET /v1/projects/:id/commits/:sha/last-commits, which returns the latest commit that changed each file and folder in a commit's tree. The new developer view on project pages uses it to show the GitHub-style "latest commit" column.How it works:
last-commitsoperation innative/gitinspectionwalks first-parent history from the commit. It compares each commit's tree with its parent's and only goes into subtrees whose hashes changed..fractchfile only counts as changed when its scripts or declarations change. Every save rewrites saved variable values and positions in every sprite file, so without this filter almost every folder showed the newest commit. With it, the results match the commit summaries. On a real 50-commit project the walk takes about 130 ms, and the result goes through the existing per-head disk cache.complete: falseand leaves the remaining paths out, rather than guessing.gitInspectionResponse, so it has the same access checks as/tree: see-inside, pull-commit access and recorded commits. The response carries author name, date and message only./tree.Response shape:
{ok, sha, paths: {path: sha}, commits: {sha: {author, date, message}}, complete}.Version: 1.3.0 to 1.4.0 (new endpoint).
Checks:
go test ./...innative/gitinspectionpasses, with new tests for:osl testpasses: 63 tests.osl lsp check main.oslreports warnings only, and they were already there.osl compileandscripts/e2e_smoke.pypass.No visible surface, so no screenshots here. The UI is in the scratch-gui developer view PR.