Repository navigation
Let project comments become issues that can be marked done - #84
Merged
Merged
Conversation
… and stop broadcasting shadow-banned comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Project comments can become issues, roturGIT style: tracked, marked done, reopened, and listed by state.
PUT /projects/:id/comments/:cid/issuewith{"state": "open" | "done" | "none"}.comment_edited.noneturns an issue back into a plain comment but keeps its number reserved, so/code/issues/<n>links never point at a different issue, and tracking the same comment again brings its number back.GET /projects/:id/commentstakes?issue=open|done|any(plus&number=N) and returns the matching issues with all their replies. Every response now includesissueCounts: {open, done}, counted after the viewer's visibility filter.issuesOff. It is saved through the normal project update and returned with the project. While it is on, opening, closing and reopening issues is refused with 403. Untracking (none) is still allowed.Version: 1.4.1 → 1.5.0 (minor, new feature).
Checks:
osl testpasses (64 files), including newcomment-issues.test.oslcases for permissions, numbering, reserved numbers, reopen, filters and counts.osl lsp checkreports no new errors,scripts/check_conventions.pypasses, andscripts/e2e_smoke.pypasses.issuesOff, everything exceptnonereturns 403.An independent review was run against the branch, and its must-fix and should-fix API findings are fixed here: the shadow-ban broadcast, number reuse, and the 403/404 existence leak.
Nothing is visible from the API alone. The UI is in the scratch-gui
comment-issuesbranch (stacked on scratch-gui #227), which follows once this is deployed.