Repository navigation
Say before an undo whether it can work - #189
Merged
Merged
Conversation
On servers with revert-check, an opened history entry asks whether its change can be undone. If it was undone already or edited away, or later changes are in the way, the entry says so instead of offering the undo. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Markus found that "Undo this change" could be tapped and confirmed, and only then said the change was gone. Backend #104 adds
GET /document/{id}/history/{revision}/revert/(featurerevert-check), which checks without changing anything.revert-check.nothing-to-revert: "Can't undo: this change was undone already or edited away." is shown instead of the button.revert-conflict: "Can't undo: later changes in Install are in the way." is shown instead of the button.Tests: the REST model with real answers of backend 6d54b9b, ViewModel and Robolectric tests, and on the emulator against that backend: an already undone change showed the text, a possible one the button.
🤖 Generated with Claude Code