Repository navigation
[DO NOT MERGE] Support configurable PushFailurePolicy on MutableStore (#678) - #769
Open
binayshaw7777 wants to merge 2 commits into
Open
binayshaw7777 wants to merge 2 commits into
binayshaw7777 wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #678
Description
In
RealMutableStore, when eager conflict resolution during a stream request fails, the error was logged anddelegate.stream(request)was invoked unconditionally (marked with// TODO(#678)). This could trigger a remote fetch that overwrites unpushed dirty local data in the Source of Truth.This PR introduces
PushFailurePolicy:FAIL_FAST: EmitsStoreReadResponse.Errorand halts without fetching.SKIP_FETCH_KEEP_LOCAL: Suppresses remote fetch and serves only local data, preserving unpushed modifications.IGNORE_AND_FETCH: Preserves legacy behavior (default).Configurable via
MutableStoreBuilder.pushFailurePolicy(policy)andStore.asMutableStore(..., pushFailurePolicy = ...).Type of Change
Test Plan
stream_givenConflictResolutionFailsAndFailFast_whenReading_thenEmitsErrorAndAbortsinRealMutableStoreTest.kt.stream_givenConflictResolutionFailsAndSkipFetchKeepLocal_whenReading_thenEmitsLocalOnlyinRealMutableStoreTest.kt../gradlew :store:jvmTest.Checklist