Repository navigation
Bugfix: a reference cited with new text locked the database - #11
Merged
Merged
Conversation
cite() found an existing citation only by its raw text, so SEAMM's own citation, whose text holds the version, was inserted again after an update and failed on the unique alias/DOI -- leaving its transaction open, which held the database's lock: a resumed SEAMM job's parallel iterations then all failed with 'database is locked' (SEAMM job 5366). Citations are now also found by alias or DOI (their text updated), a failed citation is rolled back, and connections wait up to 30 s for a lock. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cite()found an existing citation only by its raw text. SEAMM's own citationholds its version in the text, so after an update it was inserted again and
failed on the unique alias/DOI ("UNIQUE constraint failed: citation.doi"),
leaving the transaction open. That held the database's lock: a resumed SEAMM job's
parallel iterations then all failed with "database is locked" (SEAMM job 5366).
date; a failed citation is rolled back; and connections wait up to 30 s for a
lock, since the iterations of a parallel loop share the job's database.
For release 0.9.4.
🤖 Generated with Claude Code