Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 2429899 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Follow-up engine turns can reuse step numbers within an assistant message. Using those numbers as React keys caused duplicate keys and incorrect reconciliation, which could omit streamed text until the view reloaded. Key main and subagent steps by their append-only array positions instead. Add regressions for repeated step numbers in both step lists.
oltolm
force-pushed
the
fix/vscode-duplicate-step-keys
branch
from
October 25, 2026 17:42
c87dee3 to
2429899
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirement or Bug
Related to #4158. Fix missing streamed text when repeated engine step numbers cause duplicate React keys.
Bug Reproduction Steps
See linked issue.
Root Cause
Engine step numbers restart for each core turn. Follow-up turns can therefore append steps with repeated numbers to the same assistant message without emitting another
TurnBegin.Using those numbers as React keys produced duplicate sibling keys and incorrect reconciliation, which could omit or leave stale streamed text until the view reloaded. Compaction steps could introduce the same collision.
This is a fundamental fix: React step identity no longer depends on engine numbering.
Code Changes
Steps are append-only, so their array positions provide stable identities. Added regress for repeated step numbers in both main-message and subagent step lists.
Behavior Changes and Affected Users
Affected modules and coverage:
ChatMessage.tsx: regression renders two main steps with the same engine number and verifies that both remain visible without duplicate-key errors.ToolRenderers.tsx: regression expands a subagent tool with repeated step numbers and verifies both steps.pnpm --dir apps/vscode run typecheck: passed.pnpm --dir apps/vscode run build: passed.pnpm lint: passed.Checklist
/approve).gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.