Repository navigation
fix(updater): clear macOS quarantine flag during self-update - #4
Merged
Merged
Conversation
iemirakman
requested review from
winball501
and
a balanced review from Copilot
October 25, 2026 00:22
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Fixes the cargo fmt check that failed on Ubuntu.
winball501
reviewed
Oct 25, 2026
winball501
left a comment
winball501
left a comment
Member
There was a problem hiding this comment.
Thanks! Clearing the macOS quarantine flag fixes the update loop.
The cargo fmt check failed on Ubuntu, so I made two small formatting fixes in selfupdate.rs: removed trailing whitespace on a blank line and fixed the indentation of .to_path_buf();. No behavior change; all checks pass now. Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove_quarantinehelper function inselfupdate.rsfor macOS targetscom.apple.quarantineextended attribute right afterdittoextraction and before application relaunchxattrexecution errors gracefully to prevent update flow blockage