Repository navigation
Free-field input: data after field 10 on one line is ERROR 1003, not dropped - #320
Open
Valladarex wants to merge 1 commit into
Open
Valladarex wants to merge 1 commit into
Valladarex wants to merge 1 commit into
Conversation
…dropped
FFIELD converted a free-field line to fields 1-10 and stopped at the 10th
comma, so values after it were dropped without a message:
"PSHELL,1,1,.1,1,,1,,,,,,1" ran as if the last value were blank, while a
reader that treats the extra fields as a continuation gives a different
model. Non-blank data after field 10 is now fatal ERROR 1003 naming the
line; trailing empty fields (",,,") are still accepted.
Test (MYSTRAN_Validation): free_field_more_than_10_fields.bdf, that PSHELL
line in a small static deck; the run must stop and write no displacements.
On current dev it runs and writes them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #319.
One commit, in
Source/LK1/L1A/INPUT_FILE_MECHANICS.f03(FFIELD).,,,) are still accepted.Test: MYSTRAN_Validation MystranSolver/MYSTRAN_Validation#36,
free_field_more_than_10_fields.bdf: that PSHELL line in a small static deck.devthe deck runs and writes them. With this PR it stops with ERROR 1003.Validation suite: with both PRs, 1 failure of 3,256 checks, the same one current
devhas without them ("mitc4 thermal strain free rectangle cylinder"). The new check passes.