Repository navigation
Scalar masses at their own DOF: DOF table labels, the CMASS component, and masses added at one DOF - #324
Open
Valladarex wants to merge 1 commit into
Open
Scalar masses at their own DOF: DOF table labels, the CMASS component, and masses added at one DOF#324Valladarex wants to merge 1 commit into
Valladarex wants to merge 1 commit into
Conversation
…, and masses added at one DOF With scalar points whose IDs sort below a grid's, scalar masses were put at other DOFs; a CMASS on a grid's T3 went to T1; and of several masses at one DOF only the first counted. Two scalar oscillators (lambda 4 and 8 by hand) with SPOINT 1, 2, 9 and GRID 99 stopped with ERROR 989 (MLL not factorisable); two CMASS4 of 1.5 and 2.5 on one scalar point with k = 12 gave lambda 8, not 3, without a message. Causes: - TDOF_PROC labelled the rows of the DOF table (point and component) with the number of components of INV_GRID_SEQ(I), the point at sequence position I, while the rows are laid out in GRID_ID order with each point's own count (CALC_TDOF_ROW_START). With scalar points and grids sequenced in another order than their IDs, rows got the wrong point and component. - MGGS_MASS_MATRIX found each point's G-set DOF from those labels (the K-th row labelled component 1) and never read the CMASS component. - Of several masses at one DOF only the first was put in MGGS. Fixes: - TDOF_PROC labels point I with its own number of components. - MGGS_MASS_MATRIX takes the DOF from TDOF_ROW_START and the CMASS component (0 or 1 for a scalar point), and adds the masses at one DOF. - A component the point does not have stops with ERROR 1362. Test (MYSTRAN_Validation): scalar_masses_eigen.bdf, three independent systems with hand eigenvalues k / m: two scalar oscillators with scalar point IDs below the grids' (4 and 8), two masses on one scalar point (3), and a CMASS2 on a grid's T3 (5). On current dev it stops with ERROR 989.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #323.
One commit, in
Source/LK1/L1B/DOF_NUMBERING.f03andSource/LK1/L1E/MASS_MATRIX_ASSEMBLY.f03.Test: MYSTRAN_Validation MystranSolver/MYSTRAN_Validation#38,
scalar_masses_eigen.bdf: three independent systems whose hand eigenvalues k / m are 3, 4, 5 and 8.devit stops with ERROR 989.Also checked on this commit alone, outside the suite (11 checks):
Validation suite: with both PRs, 1 failure of 3,259 checks, the same one current
devhas without them ("mitc4 thermal strain free rectangle cylinder"). The 4 new checks pass.