Repository navigation
BUSH forces: the global-to-basic transform of the node forces used one component three times - #326
Open
Valladarex wants to merge 1 commit into
Open
Valladarex wants to merge 1 commit into
Valladarex wants to merge 1 commit into
Conversation
…e component three times In CALC_ELEM_NODE_FORCES (BUSH), the node forces of a grid with a non-basic CD were taken to basic as T0G(J,1)*PEG(J) + T0G(J,2)*PEG(J) + T0G(J,3)*PEG(J): the same component three times instead of the three components, and when grid B was in basic the copy for it overwrote all 12 terms, grid A's too. The BUSH engineering forces were then wrong whenever the BUSH's second grid has a rotated output system (with the first grid rotated and the second in basic they came out right). Each grid's forces and moments are now transformed with all three components, and each grid writes only its own 6 terms. Test (MYSTRAN_Validation): cbush_rotated_cd_forces.bdf, a CBUSH between coincident grids in a rotated CD, the first fixed, a load (30, 50, 80, 6, 0, 8) in basic on the second: the BUSH forces must equal the load. Current dev gives (13.7, 25.5, 39.0, 2.5, -5.8, 3.5).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #325.
One commit, in
Source/LK9/L92/ELEMENT_RECOVERY_SUPPORT.f03.Test: MYSTRAN_Validation MystranSolver/MYSTRAN_Validation#39,
cbush_rotated_cd_forces.bdf: a CBUSH between coincident grids in a rotated CD, the first fixed, with a load in basic of (30, 50, 80, 6, 0, 8) on the second.devthey are (13.7, 25.5, 39.0, 2.5, -5.8, 3.5). With this PR they equal the load.Also checked on
dev:Validation suite: with both PRs, 1 failure of 3,261 checks, the same one current
devhas without them ("mitc4 thermal strain free rectangle cylinder"). The 6 new checks pass.