Repository navigation
GRID_PROC: a scalar point listed more than once is one scalar point - #336
Open
Valladarex wants to merge 1 commit into
Open
Valladarex wants to merge 1 commit into
Valladarex wants to merge 1 commit into
Conversation
A scalar point listed on two SPOINT entries (or twice on one) stopped the run with ERROR 1344 (duplicate grid). GRID_PROC now merges repeated SPOINT listings before the duplicate check: it keeps the first, compacts GRID and RGRID, reallocates them with the new row count NGRID (SORT_GRID_RGRID takes them as explicit-shape arrays of NGRID rows, so a larger allocation shifted their columns whenever rows were swapped), sets LGRID to NGRID, lowers LDOFG and NSPOINT by the number dropped, and writes an INFORMATION line. A GRID and an SPOINT with the same ID are still a duplicate (ERROR 1344). Test (MYSTRAN_Validation): spoint_repeated_unsorted.bdf, scalar points listed out of order, between GRID entries, by THRU and repeated, in a chain of springs of 1000 with a unit load: u31, u32, u33, u40 = 1, 2, 3, 4 E-3 (hand values). Current dev stops with ERROR 1344.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #335.
One commit, in
Source/LK1/L1B/GRID_COORDINATE_PROCESSING.f03. GRID_PROC merges repeated SPOINT listings before the duplicate check:A GRID and an SPOINT with the same ID are still a duplicate (ERROR 1344).
Test: MYSTRAN_Validation MystranSolver/MYSTRAN_Validation#44,
spoint_repeated_unsorted.bdf: scalar points listed out of order, between GRID entries, by THRU and repeated, in a chain of springs of 1000.devit stops with ERROR 1344. With this PR all four pass.Validation suite: with both PRs, 1 failure of 3,259 checks, the same one current
devhas without them ("mitc4 thermal strain free rectangle cylinder"). The 4 new checks pass.