Repository navigation
CTETRA with 10 grids: accept either corner order - #338
Open
Valladarex wants to merge 1 commit into
Open
Valladarex wants to merge 1 commit into
Valladarex wants to merge 1 commit into
Conversation
A 10-node CTETRA whose corners G1, G2, G3 are clockwise seen from G4 failed element generation with negative volume and Jacobian (errors 1925 and 1928). 4-node CTETRA take either order. Every TETRA10 of NASA's HIRENASD model (195,924 elements) is in the clockwise order. ORIENT_TETRA10 (ELEMENT_LOOKUPS) runs once in LINK1, after the grids are in basic coordinates. For each 10-node CTETRA with negative corner volume it swaps G2 and G3 in EDAT, and the midside grids follow their edges: G1 G3 G2 G4, then the grids of edges 1-3, 3-2, 2-1, 1-4, 3-4, 2-4. Every later use of the element (stiffness, mass, loads, recovery) sees the same order. An information line gives the number of elements reordered. Test (MYSTRAN_Validation): tet10_orientation_lh.bdf, a 10-node CTETRA listed with its corners clockwise: it must give the displacements of the same element listed counterclockwise. Current dev stops with ERROR 1925/1928.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #337.
One commit, in
Source/EMG/EMG1/ELEMENT_LOOKUPS.f03andSource/LK1/LINK1/LINK0_LINK1.f03.Test: MYSTRAN_Validation MystranSolver/MYSTRAN_Validation#45,
tet10_orientation_lh.bdf: one 10-node CTETRA listed with corners 1 3 2 4, under a unit load at G4.devit stops with ERROR 1925 and 1928. With this PR all four pass.Validation suite: with both PRs, 1 failure of 3,259 checks, the same one current
devhas without them ("mitc4 thermal strain free rectangle cylinder"). The 4 new checks pass.