Skip to content

Adopt project-template and the NCode Review bot #1

Closed

Description

@polewskm

Bring PasswordGenerator under NCodeGroup/project-template and turn on the NCode Review bot, so it gets the plan-then-execute workflow, agent instructions, CI and Dependabot defaults, and AI code review on its pull requests.

Context: This DI friendly library provides the ability to generate strong cryptographically random passwords that meet the OWASP requirements (length, lower case, upper case, numeric, and special characters).. Default branch main, last pushed 2023-07-16.

1. Adopt the template

Run .\Adopt-Project.ps1 -Path <clone> from a project-template clone, on a clean working tree. It works out the template's answers from the repository, applies the template, runs the build and test commands, and makes one commit. See the template's README, "Adopt an Existing Repository".

  • The repository already has a GitHub Actions workflow, .github/workflows/main.yml. Either let the template's ci.yml replace it, or keep it and adopt with -Data @{ project_owned_files = '.github/workflows/ci.yml' }, so updates show the template's changes instead of merging them.
  • Pass -Data @{ workflow_tools = 'claude', 'copilot' }: without it the repository gets the Hybrid agents, which use the private local model.
  • Answer nuget_package: true with a license, if this library ships a package.
  • It has no AGENTS.md, decision records or .github/instructions yet. Adoption adds AGENTS.md; fill in its conventions, since the bot hands them to every reviewer.

2. Turn on the NCode Review bot

NCodeGroup/code-review posts as ncode-review[bot]: a "Code review" check run, a summary comment with a verdict, and inline threads. It reviews a pull request when it opens (drafts included) and when it's marked ready, skips a commit it already reviewed, and reviews on demand on a /review comment from someone with write access. Nothing requires it, and it costs this repository nothing: the keys are NCodeGroup organization secrets.

  • After step 1, either the template's caller arrives through the template (code_review: true, once project-template#107 ships), or install a copy of Identity's .github/workflows/code-review-trial.yml pinned to an exact release tag.
  • Run tools/Enable-CodeReview.ps1 -Repo PasswordGenerator from a code-review clone. It creates the code-review environment and gives this repository the organization secrets.
  • Its learned rules cover what this repository's code does: allocation, buffers, encoding, errors and validation, async, public API and testing. They are matched by file glob, so a library with *.cs files gets them without writing any rules of its own.

Dependencies

  • NCodeGroup/project-template#105: the template's source is still polewskm/project-template, and Adopt-Project.ps1 defaults to it. Adopt from the NCodeGroup repository once that moves, or pass -Template and -Ref until then.
  • NCodeGroup/project-template#107: offers the bot as a template question, with a caller workflow pinned to an exact release tag.
  • NCodeGroup/code-review#14: release tags, so the bot can be pinned to an exact version.

Activity

  1. polewskm commented on Nov 4, 2026

    @polewskm
    ContributorAuthor

    Autopilot: done, closing. This repository is under project-template (.copier-answers.yml with code_review: true) and NCode Review reviews its pull requests. PR #12 brings the template to v0.61.2 and the bot to v1.1.2.


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions