Skip to content

A /review command is the comment's first line - #173

Merged
polewskm merged 6 commits into
mainfrom
claude/jolly-cerf-loz3xs
Nov 2, 2026
Merged

polewskm merged 6 commits into
mainfrom
claude/jolly-cerf-loz3xs

Conversation

@polewskm

@polewskm polewskm commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

A /review comment followed by a footer, like the --- / _Generated by …_ lines agents add, joined the pull request's concurrency group. It cancelled the review in progress, and the engine then rejected it. The engine (parseCommand) now reads the command from the comment's first line, in any case. /review explain and /review teach drop everything from a thematic-break line on, so a footer never ends up in a question or a taught rule. The caller's concurrency group (the workflow and the README's copy) puts a comment in the pull request's group only when its first line is exactly /review. Any other comment that starts with /review gets a group of its own, so it can't cancel a review. The decision is recorded as ADR-1001, and the changelog has the 1.1.2 section to release from.

After the merge, prove the fromJSON('"\n"') group expression live: comment /review and then /review please, and the first run must not be cancelled. Then comment /review plus a footer, and it must replace the run in progress.

Closes #172


Generated by Claude Code

@polewskm
polewskm deployed to code-review November 2, 2026 22:49 — with GitHub Actions Active

@ncode-review ncode-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 NCode Review at 8c88b7f: 3 new findings on the changed lines.

Comment thread test/command.test.ts Resolved
Comment thread test/command.test.ts Resolved
Comment thread CHANGELOG.md Resolved
@ncode-review

ncode-review Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Superseded by the review at a5c6555.

@polewskm

polewskm commented Nov 2, 2026

Copy link
Copy Markdown
Contributor Author

/review

@ncode-review

ncode-review Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

🤖 Review complete

Verdict: ✅ Approve — Re-review of what changed since the last review at 8c88b7f: 1 hunk in 1 file and changes taken back in 1 file, by correctness only. No further findings above nits.

1 reviewer run — 0 findings (run details)

Reviewer Model Findings Top
correctness sonnet-5-5 0 🟢

Trial: findings are posted as review threads and in the check run. $0.02 on Amazon Bedrock, 8s, at a5c6555. (how to interact)

📋 Outcomes

Merged at a5c6555: 2 fixed, 1 dismissed, 0 acknowledged, 0 ignored.

Finding Reviewer Severity Outcome
F1 tests 🟡 Nit ✅ fixed
F2 tests 🟡 Nit ✅ fixed
F3 rule-check 🟡 Nit 👎 dismissed

@polewskm
polewskm marked this pull request as ready for review November 2, 2026 22:57
@polewskm
polewskm enabled auto-merge November 2, 2026 22:57
@polewskm
polewskm deployed to code-review November 2, 2026 22:57 — with GitHub Actions Active
@polewskm
polewskm merged commit 564bb16 into main Nov 2, 2026
9 checks passed
@polewskm
polewskm deleted the claude/jolly-cerf-loz3xs branch November 2, 2026 22:59

This branch was successfully deployed

1 active deployment
code-review — a5c65551 Deployed Nov 2, 2026 by polewskm via review #592
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A /review comment with trailing text cancels the review in progress and then does nothing

1 participant