fix(observer): emit every Prometheus series once - #381
Merged
Conversation
Completed-wait metrics were accidentally rendered inside the scale-set loop. The observer therefore emitted each aggregate ten times and the collector dropped 126 conflicting samples every scrape. Render the aggregates once and enforce global series uniqueness in the metrics test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The completed-wait metrics added in #379 were rendered inside the outer scale-set loop. With ten configured scale sets, the observer emitted each of fourteen series ten times; the OpenTelemetry collector accepted the first and dropped 126 conflicting samples on every scrape as
different value but same timestamp.This moves the aggregate metrics outside that loop and adds a renderer-wide invariant test that rejects every duplicate Prometheus series, not only this metric family.
Verification:
go test ./internal/fleetobservemake verifygha-services: healthy endpoint, zero duplicate series, zero collector duplicate-timestamp warnings after restartNo private identity, host, tenant, or runtime evidence is included in this public change.